chore(deps): remove orphaned cloudflare-go/v7 from go.mod#141
Merged
Conversation
Commit 5551e67 ("Update module github.com/cloudflare/cloudflare-go/v6 to v7") added v7 v7.3.0 to go.mod but did not migrate any source files from v6. Every internal/cloudflare/*.go still imports v6 — nothing imports v7 — so the v7 require was a stale artifact of an incomplete migration. `go mod tidy` removes it. This unblocks any in-flight tooling that inspects go.mod for consistency and removes the trap that PR #140 walked into (Renovate tried to replace v6→v7 by substitution and ended up with a duplicate v7 require line). A real v6→v7 code migration remains a separate task. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 0.19.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/cloudflare/cloudflare-go/v7 v7.3.0require entry fromgo.mod(and correspondinggo.sumline) viago mod tidy.go.modbut migrated zero code — everyinternal/cloudflare/*.gostill importscloudflare-go/v6. The v7 entry was a stale leftover from an incomplete migration.Context
PR #140 (Renovate: v6 → v7) tries to replace v6 with v7 by string substitution, which would (a) leave duplicate
v7 v7.3.0lines ingo.modand (b) break the build because v6 is still imported. This PR doesn't migrate the code — it just clears the orphan so the half-migration trap is gone. A real v6→v7 code migration remains separate work; PR #140 cannot merge until that's done.Test plan
go build ./...cleango vet ./...clean