Bug and documentation fixes for jbplot_ensemble#22
Open
MOshima-PIFSC wants to merge 2 commits into
Open
Conversation
…_forPR documented single.plots arg, changed png file name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jabbamodel
When working with JABBA I realized that the
single.plotsargument ofjbplot_ensemble()was not documented but it is a very useful argument if one needs to display the subplots singularly so I added in the parameter to the documentation. Also, when trying to save the figure as a png I was getting errors becauseoutput.dir,prefix, andjabba$assessmentwere not defined variables (line 230). I changed these variable names to match the input arguments (plotdir,filenameprefix, and "jabba_comparison.png" respectively).If you would like me to do anything additional for this PR, please let me know.
Thank you!