ci: fix golangci-lint-action version (v8) and validate CI on real runners#9
Merged
Conversation
golangci-lint-action v6 only supports golangci-lint v1.x; the repo uses golangci-lint v2 config, which requires action v8 (supports >= v2.1.0).
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the lint job in CI and serves to validate the full CI suite on GitHub's real runners (the workflows were just introduced).
golangci-lint-action@v6only supports golangci-lint v1.x, but the repo's.golangci.ymlis v2 config (validated locally with golangci-lint v2.5.0). Action v8 supports golangci-lint >= v2.1.0, so the lint job is bumped to@v8.What this PR exercises
testmatrix: Go 1.17–1.23 × {ubuntu, macOS, windows}race + coverage(Codecov, tokenless)lint: gofmt check + golangci-lint v2.5.0Local verification
go build,go vet,golangci-lint run(v2.5.0) — cleango test -race— pass, coverage 90%https://claude.ai/code/session_01P1nZkYKTFp9CRKDUEysphw
Generated by Claude Code