Remove legacy repo path support by j178 · Pull Request #2150 · j178/prek

j178 · 2026-06-04T10:50:56Z

Remove legacy store repo_path fallback.

Copilot

Pull request overview

This PR removes the legacy Store::repo_path() fallback that preferred an existing “legacy” repo directory layout, making the store always use the current repo_key()-derived path for remote repositories.

Changes:

Remove legacy repo path detection and legacy key/path helpers from Store.
Simplify hashing imports now that DefaultHasher is no longer used.
Remove unit tests that validated the legacy fallback behavior.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70084c606f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-04T10:52:52Z

-            return legacy_path;
-        }
-
        self.repos_dir().join(Self::repo_key(repo))


Restore legacy cache lookup until a breaking release

For users upgrading from releases that cached clones under the old DefaultHasher key, repo_path() now only checks the new SeaHasher directory even though the workspace version is still 0.4.4. In that environment an existing cached repo with .prek-repo.json is ignored, so clone_repos() will try to re-clone private/offline repositories and cache_gc can later treat the legacy clone as unused; this regresses the compatibility path that was explicitly added to keep cached clones working until the next breaking release.

Useful? React with 👍 / 👎.

prek-ci-bot · 2026-06-04T10:57:46Z

📦 Cargo Bloat Comparison

Binary size change: +0.76% (26.3 MiB → 26.5 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  90.0KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  81.9KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.5%  69.8KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  62.6KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  48.3KiB              prek prek::run::{{closure}}
 0.2%   0.3%  44.0KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.2%  31.4KiB             prek? <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  30.6KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  29.6KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  28.1KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.1KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  24.4KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  23.0KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.8KiB     serde_saphyr? <serde_saphyr::de::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map
42.0%  86.5%  11.1MiB                   And 24142 smaller methods. Use -n N to show more.
48.6% 100.0%  12.9MiB                   .text section size, the file size is 26.5MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  89.9KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  80.4KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.5%  69.8KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  62.1KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  48.1KiB              prek prek::run::{{closure}}
 0.2%   0.3%  44.1KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.2%  31.9KiB             prek? <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  30.6KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  29.6KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  28.1KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.9KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  24.3KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  23.0KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.8KiB     serde_saphyr? <serde_saphyr::de::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map
41.7%  86.4%  11.0MiB                   And 24094 smaller methods. Use -n N to show more.
48.3% 100.0%  12.7MiB                   .text section size, the file size is 26.3MiB

prek-ci-bot · 2026-06-04T10:57:47Z

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment

OS: Linux 6.17.0-1015-azure
CPU: 4 cores
prek version: prek 0.4.4+2 (befbfa2 2026-06-04)
Rust version: rustc 1.96.0 (ac68faa20 2026-05-25)
Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

`prek --version`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base --version`	2.2 ± 0.1	2.0	3.0	1.06 ± 0.07
`prek-head --version`	2.1 ± 0.1	2.0	2.5	1.00

`prek list`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base list`	8.8 ± 0.6	8.5	14.9	1.01 ± 0.07
`prek-head list`	8.7 ± 0.1	8.4	8.9	1.00

`prek validate-config .pre-commit-config.yaml`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base validate-config .pre-commit-config.yaml`	2.9 ± 0.1	2.8	3.6	1.00 ± 0.04
`prek-head validate-config .pre-commit-config.yaml`	2.9 ± 0.1	2.8	3.4	1.00

`prek sample-config`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base sample-config`	2.5 ± 0.4	2.3	5.0	1.02 ± 0.16
`prek-head sample-config`	2.4 ± 0.0	2.3	2.5	1.00

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

`prek run --all-files (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	77.7 ± 2.8	73.7	82.7	1.02 ± 0.05
`prek-head run --all-files`	76.0 ± 2.5	72.2	80.0	1.00

`prek run --all-files (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	75.8 ± 2.8	71.8	83.0	1.00
`prek-head run --all-files`	77.1 ± 3.2	72.2	84.2	1.02 ± 0.06

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

`prek run --all-files (full builtin hook suite)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	76.4 ± 3.4	71.8	84.4	1.00
`prek-head run --all-files`	77.1 ± 3.2	72.1	82.8	1.01 ± 0.06

Individual Hook Performance

Benchmarking each hook individually on the test repo:

`prek run trailing-whitespace --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run trailing-whitespace --all-files`	20.3 ± 0.4	19.5	21.1	1.03 ± 0.03
`prek-head run trailing-whitespace --all-files`	19.8 ± 0.4	19.2	20.3	1.00

`prek run end-of-file-fixer --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run end-of-file-fixer --all-files`	25.6 ± 2.3	23.0	30.5	1.00
`prek-head run end-of-file-fixer --all-files`	26.7 ± 2.1	23.4	31.5	1.04 ± 0.12

`prek run check-json --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-json --all-files`	7.4 ± 0.2	7.2	7.7	1.00
`prek-head run check-json --all-files`	7.6 ± 0.2	7.2	8.3	1.02 ± 0.04

`prek run check-yaml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-yaml --all-files`	7.2 ± 0.1	7.0	7.4	1.00
`prek-head run check-yaml --all-files`	7.3 ± 0.1	7.1	7.6	1.01 ± 0.02

`prek run check-toml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-toml --all-files`	7.4 ± 0.3	7.0	8.1	1.00 ± 0.06
`prek-head run check-toml --all-files`	7.4 ± 0.4	7.0	8.9	1.00

`prek run check-xml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-xml --all-files`	7.4 ± 0.3	7.0	8.1	1.00
`prek-head run check-xml --all-files`	7.5 ± 0.3	6.9	8.0	1.00 ± 0.06

`prek run detect-private-key --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run detect-private-key --all-files`	13.0 ± 1.3	11.0	16.0	1.00
`prek-head run detect-private-key --all-files`	13.5 ± 1.1	11.6	15.4	1.04 ± 0.13

`prek run fix-byte-order-marker --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run fix-byte-order-marker --all-files`	21.6 ± 1.7	19.2	25.4	1.00
`prek-head run fix-byte-order-marker --all-files`	21.9 ± 1.6	19.4	24.3	1.02 ± 0.11

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

`prek install-hooks (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	4.4 ± 0.0	4.3	4.4	1.01 ± 0.01
`prek-head install-hooks`	4.3 ± 0.0	4.3	4.4	1.00

`prek install-hooks (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	4.4 ± 0.1	4.3	4.4	1.00
`prek-head install-hooks`	4.4 ± 0.2	4.3	4.7	1.02 ± 0.04

File Filtering/Scoping Performance

Testing different file selection modes:

`prek run (staged files only)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run`	36.8 ± 0.8	35.3	38.5	1.00
`prek-head run`	37.6 ± 1.3	36.2	41.2	1.02 ± 0.04

`prek run --files '*.json' (specific file type)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --files '*.json'`	7.8 ± 0.1	7.6	8.0	1.00
`prek-head run --files '*.json'`	7.8 ± 0.1	7.7	8.0	1.01 ± 0.01

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

`prek run --dry-run --all-files (measures init overhead)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --dry-run --all-files`	6.7 ± 0.1	6.6	6.8	1.00
`prek-head run --dry-run --all-files`	6.7 ± 0.1	6.5	6.9	1.00 ± 0.02

Meta Hooks Performance

Benchmarking meta hooks separately:

`prek run check-hooks-apply --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-hooks-apply --all-files`	11.4 ± 0.7	10.3	12.6	1.04 ± 0.13
`prek-head run check-hooks-apply --all-files`	11.0 ± 1.3	10.3	13.7	1.00

`prek run check-useless-excludes --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-useless-excludes --all-files`	10.4 ± 0.1	10.2	10.6	1.01 ± 0.01
`prek-head run check-useless-excludes --all-files`	10.3 ± 0.1	10.1	10.4	1.00

`prek run identity --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run identity --all-files`	9.6 ± 0.1	9.4	9.7	1.01 ± 0.01
`prek-head run identity --all-files`	9.5 ± 0.1	9.4	9.7	1.00

codecov · 2026-06-04T11:00:44Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.51%. Comparing base (f44270e) to head (70084c6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2150      +/-   ##
==========================================
- Coverage   92.52%   92.51%   -0.02%     
==========================================
  Files         122      122              
  Lines       26016    25978      -38     
==========================================
- Hits        24071    24033      -38     
  Misses       1945     1945

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Remove legacy repo path support

70084c6

Copilot AI review requested due to automatic review settings June 4, 2026 10:50

j178 added the enhancement New feature or request label Jun 4, 2026

Copilot started reviewing on behalf of j178 June 4, 2026 10:51 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

j178 merged commit aca63ee into master Jun 4, 2026
33 checks passed

j178 deleted the repo-path branch June 4, 2026 11:00

Uh oh!

Conversation

j178 commented Jun 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

prek-ci-bot Bot commented Jun 4, 2026

📦 Cargo Bloat Comparison

Head Branch Results

Base Branch Results

Uh oh!

prek-ci-bot Bot commented Jun 4, 2026

⚡️ Hyperfine Benchmarks

prek --version

prek list

prek validate-config .pre-commit-config.yaml

prek sample-config

prek run --all-files (cold - no cache)

prek run --all-files (warm - with cache)

prek run --all-files (full builtin hook suite)

prek run trailing-whitespace --all-files

prek run end-of-file-fixer --all-files

prek run check-json --all-files

prek run check-yaml --all-files

prek run check-toml --all-files

prek run check-xml --all-files

prek run detect-private-key --all-files

prek run fix-byte-order-marker --all-files

prek install-hooks (cold - no cache)

prek install-hooks (warm - with cache)

prek run (staged files only)

prek run --files '*.json' (specific file type)

prek run --dry-run --all-files (measures init overhead)

prek run check-hooks-apply --all-files

prek run check-useless-excludes --all-files

prek run identity --all-files

Uh oh!

Uh oh!

codecov Bot commented Jun 4, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`prek --version`

`prek list`

`prek validate-config .pre-commit-config.yaml`

`prek sample-config`

`prek run --all-files (cold - no cache)`

`prek run --all-files (warm - with cache)`

`prek run --all-files (full builtin hook suite)`

`prek run trailing-whitespace --all-files`

`prek run end-of-file-fixer --all-files`

`prek run check-json --all-files`

`prek run check-yaml --all-files`

`prek run check-toml --all-files`

`prek run check-xml --all-files`

`prek run detect-private-key --all-files`

`prek run fix-byte-order-marker --all-files`

`prek install-hooks (cold - no cache)`

`prek install-hooks (warm - with cache)`

`prek run (staged files only)`

`prek run --files '*.json' (specific file type)`

`prek run --dry-run --all-files (measures init overhead)`

`prek run check-hooks-apply --all-files`

`prek run check-useless-excludes --all-files`

`prek run identity --all-files`