Fix segfault when calling yaconv more than once#1
Open
jaopaulolc wants to merge 1 commit into
Open
Conversation
yaconv_init_once relies on checking if filter_buf is null to detect if it is allocated. The problem is that calling free on filter_buf does not set said pointer to null. This commit fixes this by setting said pointer to null upon deinit. This commit also frees auxinfo to avoid a memory leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yaconv_init_once relies on checking if filter_buf is null to detect if it is allocated. The problem is that calling free on filter_buf does not set said pointer to null. This commit fixes this by setting said pointer to null upon deinit.
This commit also frees auxinfo to avoid a memory leak.
Bug was identified by @caio96