Skip to content

Allow specifying dates to fetch transaction history within those dates #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mehere wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow specifying dates to fetch transaction history within those dates #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion schwab_api/schwab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,12 @@ def get_account_info(self):

return account_info

def get_transaction_history_v2(self, account_id):
def get_transaction_history_v2(self, account_id, from_date=None, to_date=None):
"""
account_id (int) - The account ID to place the trade on. If the ID is XXXX-XXXX,
we're looking for just XXXXXXXX.
from_date (datetime.date) - the date the transaction history starts from. Leave it empty to search for all.
to_date (datetime.date) - the date the transaction history ends with. Leave it empty to search for all.

Returns a dictionary of transaction history entries for the provided account ID.
"""
Expand Down Expand Up @@ -116,6 +118,11 @@ def get_transaction_history_v2(self, account_id):
"sortColumn": "Date",
"sortDirection": "Descending"
}
if from_date and to_date:
data["timeFrame"] = "SpecifyDateRange"
data["fromDate"] = from_date.strftime('%Y-%m-%d')
data["toDate"] = to_date.strftime('%Y-%m-%d')

r = requests.post(urls.transaction_history_v2(), json=data, headers=self.headers)
if r.status_code != 200:
return [r.text], False
Expand Down