Clarify JOREK neighbour sentinels#392
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The JOREK restart reader says
-1is the boundary marker forneighbours. Model-303 restarts can contain two nonpositive sentinels:-1at collapsed-axis sides and0at physical-boundary sides. The reader already preserves both values, but its public contract and synthetic round-trip fixture cover only-1.This PR documents the stored-value contract and adds
0to the existing synthetic round trip. It changes no read path.Numerical and interface invariants
Verification
Test fails on main
The documented nonpositive-sentinel contract and zero fixture are absent:
Test passes after fix