Regularize JOREK axis field evaluation#389
Merged
Merged
Conversation
a5cb8f3 to
fc6d484
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The off-axis Hermite field, Newton locator, component ordering, and units are unchanged. At the coordinate singularity, the implementation extrapolates the physical flux gradient before applying the exact axis radius. The extrapolation uses normalized element radii 1e-2 and 1e-3; the analytic axis regression uses a relative tolerance of 1e-12.
Verification
Red before the implementation:
Green after the implementation:
foStatic: OK (228 modules, 228 changed, 228 affected)Build: OKctest --test-dir /tmp/libneo-axis-build -R jorek --output-on-failure100% tests passed, 0 tests failed out of 5B_phi = F0/R_axisexactly