Expose NEO-2-QL integral iteration limit#156
Draft
krystophny wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #155.
The QL input now exposes the existing integral-part iteration limit as
niter, keeps the current default of 1000, rejects nonpositive values before solver setup, and records the selected value inneo2_config.h5. The ripple solver uses that configured module value instead of overwriting it locally.The numerical invariant is unchanged at default input: the iteration limit remains 1000, and the loop body,
epserr_iterstopping criterion, collision operator, source terms, flux-conservation operations, ABI, and data layout are unchanged.Verification
fo test ql_niter_validation_testfailed (0 passed, 1 failed) becauseniterwas not accepted by the QL settings namelist.fo test ql_niter_validation_testpasses (1 passed, 0 failed) and exercises the nonpositive-value rejection through the QL executable.ctest --test-dir build -R 'boozmn_read_test|nrutil_test|er_rotation_test|spline_sparse_assembly_test|ql_niter_validation_test|test_mympilib' --output-on-failurepasses all 6 self-contained tests.foreportsStatic: OKandBuild: OK, then cannot complete the legacy reconstruction tests because their site-only templates and reference files are unavailable in this environment.fo lintreports the existing 195 compiler warnings and 2 unused imports.