Reject unsupported periodic collision models#184
Open
krystophny wants to merge 1 commit into
Open
Conversation
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The periodic-Fourier driver currently assembles the restored Krook kernels regardless of collision_model. Reject every model except Krook until a continuum Fokker-Planck kernel is implemented, so an input cannot silently claim different collision physics.
Invariant: the supported Krook periodic assembly, Fourier convention, CGS units, grid, dense solve, and boundary behavior are unchanged.
Verification
Failing before, using the parent binary with collision_model = FokkerPlanck:
Passing after, using the same input:
Relation to Markus's Fokker-Planck periodic branch
This guard closes a real semantic hole in the independent stack: a Krook kernel must not run under a Fokker-Planck label. Keep the guard until #187 verifies the FP kernel and #190 accepts the FP benchmark. #191 must replace the blanket rejection with explicit Krook/FP dispatch, not remove collision-model validation.