Export the global JOREK boundary-hole map#63
Open
krystophny wants to merge 1 commit into
Open
Conversation
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PR #62 proves that most source-element misses are covered elsewhere in the complete factor-8 plane. This PR exports the remaining global misses and classifies their JOREK adjacency.
CTest now writes one CSV row per unique poloidal hole with the source element, local coordinates, physical
(R,Z), and four restart-neighbor values.This PR is stacked on #62.
Adjacency convention
The retained restart uses both nonpositive sentinels:
-1occurs on the 115 collapsed-axis elements;0marks physical-boundary sides, with 183 occurrences across 179 elements.The existing libneo comment says only
-1marks boundaries and is incomplete. This diagnostic treats every nonpositive neighbor as a boundary sentinel.Result
The CSV has 74 data rows distributed across 59 consecutive elements,
5769:5827. Every hole element hasneighbor_2=0and no negative neighbor. There are no holes from elements whose four neighbors are positive.(s,t)=(5/6,1/6)(s,t)=(0.9,0.1)The physical locations trace one boundary strip over
R=1.19554...2.13819 mandZ=-0.603215...0.793108 m. The 74 points are curved physical-boundary slivers excluded by the straight factor-8 chords, not interior topology holes.The next plane-only diagnostic should run complete global containment at factor 16. That determines whether physical-boundary holes and overlap multiplicity contract before any boundary-node or volume-topology change.
Numerical and physics invariants
Verification
Test fails on main
The parent diagnostic accepts no output path and produces no hole map:
Test passes after fix