fix(hook): drop proposal accept/reject approval guard#76
Closed
itlackey wants to merge 1 commit into
Closed
Conversation
The PreToolUse guard on `akm proposal accept|reject` blocked authorized automated review of the proposal queue, and the regex was start-anchored (trivially bypassed by `bun .../cli.js proposal ...`), so it added friction without being a real stop. Removed the Bash hard-block and the proposal references from the prompt-expansion note; left the memory-promote/reject note and the other risky-command guards intact. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the PreToolUse guard that blocked
akm proposal accept|reject(and the proposal references in the prompt-expansion note).Why: it blocked legitimately-authorized automated review of the proposal queue, and the regex was start-anchored —
bun .../cli.js proposal accept …sidestepped it entirely — so it added friction without being a real stop.Kept intact: the memory-promote/reject note and all the other risky-command guards (
save --push,remove,update --all,upgrade, vault, config, trusted-source, secret-redaction).Merge then
/plugin update akmto propagate into the installed cache (this also collapses the stale0.8.0-rc.1/0.8.0-rc.8cached versions back to a single clean install).🤖 Generated with Claude Code