Skip to content

feat: admin tests #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kristinaxm merged 2 commits into from
Apr 23, 2026
Merged

feat: admin tests #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46ff598
feat: admin tests
kristinaxm Apr 23, 2026
44de671
Merge branch 'main' into feature/admincontroller-tests
kristinaxm Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 26 additions & 15 deletions src/main/java/org/example/team6backend/admin/AdminController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,14 @@ public ResponseEntity<UserResponse> approveUser(@PathVariable String userId) {
public ResponseEntity<UserResponse> updateUserRole(@PathVariable String userId,
@Valid @RequestBody UpdateUserRoleRequest request, @AuthenticationPrincipal CustomUserDetails currentUser) {

log.info("PATCH /api/admin/users/{}/role - Admin {} changing role to {}", userId,
currentUser.getUser().getGithubLogin(), request.role());
String currentUserLogin = currentUser != null && currentUser.getUser() != null
? currentUser.getUser().getGithubLogin()
: "unknown";

if (currentUser.getUser().getId().equals(userId)) {
log.info("PATCH /api/admin/users/{}/role - Admin {} changing role to {}", userId, currentUserLogin,
request.role());

if (currentUser != null && currentUser.getUser() != null && currentUser.getUser().getId().equals(userId)) {
log.warn("User {} attempted to change their own role", userId);
throw new IllegalStateException("You cannot change your own role");
}
Expand All @@ -93,16 +97,15 @@ public ResponseEntity<UserResponse> updateUserRole(@PathVariable String userId,
if (targetUser.getRole() == UserRole.ADMIN) {
long adminCount = userService.getAllUsers().stream().filter(u -> u.getRole() == UserRole.ADMIN).count();
if (adminCount <= 1) {
log.warn("Attempt to remove last admin user {} by {}", userId,
currentUser.getUser().getGithubLogin());
log.warn("Attempt to remove last admin user {} by {}", userId, currentUserLogin);
throw new IllegalStateException("Cannot remove the last admin user");
}
}
}

AppUser updatedUser = userService.updateUserRole(userId, request.role());
log.info("User {} role changed from {} to {} by admin {}", updatedUser.getGithubLogin(), updatedUser.getRole(),
request.role(), currentUser.getUser().getGithubLogin());
log.info("User {} role changed to {} by admin {}", updatedUser.getGithubLogin(), request.role(),
currentUserLogin);

return ResponseEntity.ok(userMapper.toResponse(updatedUser));
}
Expand All @@ -112,17 +115,22 @@ public ResponseEntity<UserResponse> updateUserStatus(@PathVariable String userId
@Valid @RequestBody UpdateUserStatusRequest request,
@AuthenticationPrincipal CustomUserDetails currentUser) {

log.info("PATCH /api/admin/users/{}/status - Admin {} setting active={}", userId,
currentUser.getUser().getGithubLogin(), request.active());
String currentUserLogin = currentUser != null && currentUser.getUser() != null
? currentUser.getUser().getGithubLogin()
: "unknown";

log.info("PATCH /api/admin/users/{}/status - Admin {} setting active={}", userId, currentUserLogin,
request.active());

if (currentUser.getUser().getId().equals(userId) && !request.active()) {
if (currentUser != null && currentUser.getUser() != null && currentUser.getUser().getId().equals(userId)
&& !request.active()) {
log.warn("User {} attempted to deactivate their own account", userId);
throw new IllegalStateException("You cannot deactivate your own account");
}

AppUser updatedUser = userService.updateUserActiveStatus(userId, request.active());
log.info("User {} active status changed to {} by admin {}", updatedUser.getGithubLogin(),
updatedUser.isActive(), currentUser.getUser().getGithubLogin());
updatedUser.isActive(), currentUserLogin);

return ResponseEntity.ok(userMapper.toResponse(updatedUser));
}
Expand All @@ -131,18 +139,21 @@ public ResponseEntity<UserResponse> updateUserStatus(@PathVariable String userId
public ResponseEntity<Void> deleteUser(@PathVariable String userId,
@AuthenticationPrincipal CustomUserDetails currentUser) {

log.info("DELETE /api/admin/users/{} - Admin {} attempting to delete user", userId,
currentUser.getUser().getGithubLogin());
String currentUserLogin = currentUser != null && currentUser.getUser() != null
? currentUser.getUser().getGithubLogin()
: "unknown";

log.info("DELETE /api/admin/users/{} - Admin {} attempting to delete user", userId, currentUserLogin);

if (currentUser.getUser().getId().equals(userId)) {
if (currentUser != null && currentUser.getUser() != null && currentUser.getUser().getId().equals(userId)) {
log.warn("User {} attempted to delete their own account", userId);
throw new IllegalStateException("You cannot delete your own account");
}

var userToDelete = userService.getUserById(userId);
userService.deleteUser(userId);
log.info("User {} ({}) deleted by admin {}", userToDelete.getGithubLogin(), userToDelete.getRole(),
currentUser.getUser().getGithubLogin());
currentUserLogin);

return ResponseEntity.noContent().build();
}
Expand Down
218 changes: 218 additions & 0 deletions src/test/java/org/example/team6backend/admin/AdminControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,218 @@
package org.example.team6backend.admin;

import org.example.team6backend.user.entity.AppUser;
import org.example.team6backend.user.entity.UserRole;
import org.example.team6backend.user.mapper.UserMapper;
import org.example.team6backend.user.service.UserService;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
import org.springframework.boot.security.oauth2.client.autoconfigure.OAuth2ClientAutoConfiguration;
import org.springframework.boot.security.oauth2.client.autoconfigure.servlet.OAuth2ClientWebSecurityAutoConfiguration;
import org.springframework.boot.webmvc.test.autoconfigure.AutoConfigureMockMvc;
import org.springframework.boot.webmvc.test.autoconfigure.WebMvcTest;
import org.springframework.data.domain.Page;
import org.springframework.data.domain.PageImpl;
import org.springframework.data.domain.PageRequest;
import org.springframework.data.domain.Pageable;
import org.springframework.http.MediaType;
import org.springframework.security.test.context.support.WithMockUser;
import org.springframework.test.context.bean.override.mockito.MockitoBean;
import org.springframework.test.web.servlet.MockMvc;

import java.time.Instant;
import java.util.Arrays;
import java.util.List;
import java.util.UUID;

import static org.mockito.ArgumentMatchers.*;
import static org.mockito.Mockito.*;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;

@WebMvcTest(AdminController.class)
@AutoConfigureMockMvc(addFilters = false)
@ImportAutoConfiguration(exclude = {OAuth2ClientAutoConfiguration.class,
OAuth2ClientWebSecurityAutoConfiguration.class})
class AdminControllerTest {

@Autowired
private MockMvc mockMvc;

@MockitoBean
private UserService userService;

@MockitoBean
private UserMapper userMapper;

private AppUser testUser;
private AppUser pendingUser;
private AppUser handlerUser;

@BeforeEach
void setUp() {
testUser = new AppUser();
testUser.setId(UUID.randomUUID().toString());
testUser.setGithubId("test123");
testUser.setGithubLogin("testuser");
testUser.setName("Test User");
testUser.setEmail("test@test.com");
testUser.setRole(UserRole.RESIDENT);
testUser.setActive(true);
testUser.setCreatedAt(Instant.now());
testUser.setUpdatedAt(Instant.now());

pendingUser = new AppUser();
pendingUser.setId(UUID.randomUUID().toString());
pendingUser.setGithubId("pending123");
pendingUser.setGithubLogin("pending");
pendingUser.setName("Pending User");
pendingUser.setEmail("pending@test.com");
pendingUser.setRole(UserRole.PENDING);
pendingUser.setActive(true);
pendingUser.setCreatedAt(Instant.now());
pendingUser.setUpdatedAt(Instant.now());

handlerUser = new AppUser();
handlerUser.setId(UUID.randomUUID().toString());
handlerUser.setGithubId("handler123");
handlerUser.setGithubLogin("handler");
handlerUser.setName("Handler User");
handlerUser.setEmail("handler@test.com");
handlerUser.setRole(UserRole.HANDLER);
handlerUser.setActive(true);
handlerUser.setCreatedAt(Instant.now());
handlerUser.setUpdatedAt(Instant.now());
}

@Test
@WithMockUser(roles = "ADMIN")
void shouldGetAllUsers() throws Exception {
Pageable pageable = PageRequest.of(0, 20);
List<AppUser> users = Arrays.asList(testUser, handlerUser, pendingUser);
Page<AppUser> userPage = new PageImpl<>(users, pageable, users.size());

when(userService.getAllUsersPaginated(any(Pageable.class))).thenReturn(userPage);
when(userMapper.toResponsePage(any(Page.class))).thenReturn(new PageImpl<>(Arrays.asList()));

mockMvc.perform(get("/api/admin/users")).andExpect(status().isOk())
.andExpect(content().contentType(MediaType.APPLICATION_JSON));
}

@Test
@WithMockUser(roles = "ADMIN")
void shouldGetUsersWithSearch() throws Exception {
String searchTerm = "test";
Pageable pageable = PageRequest.of(0, 20);
List<AppUser> users = Arrays.asList(testUser);
Page<AppUser> userPage = new PageImpl<>(users, pageable, users.size());

when(userService.searchUsers(eq(searchTerm), any(Pageable.class))).thenReturn(userPage);
when(userMapper.toResponsePage(any(Page.class))).thenReturn(new PageImpl<>(Arrays.asList()));

mockMvc.perform(get("/api/admin/users").param("search", searchTerm)).andExpect(status().isOk());
}

@Test
@WithMockUser(roles = "ADMIN")
void shouldGetPendingUsers() throws Exception {
Pageable pageable = PageRequest.of(0, 20);
List<AppUser> pendingUsers = Arrays.asList(pendingUser);
Page<AppUser> pendingPage = new PageImpl<>(pendingUsers, pageable, pendingUsers.size());

when(userService.getUsersByRolePaginated(eq(UserRole.PENDING), any(Pageable.class))).thenReturn(pendingPage);
when(userMapper.toResponsePage(any(Page.class))).thenReturn(new PageImpl<>(Arrays.asList()));

mockMvc.perform(get("/api/admin/users/pending")).andExpect(status().isOk());
}

@Test
@WithMockUser(roles = "ADMIN")
void shouldGetUserById() throws Exception {
String userId = testUser.getId();

when(userService.getUserById(userId)).thenReturn(testUser);
when(userMapper.toResponse(any(AppUser.class))).thenReturn(null);

mockMvc.perform(get("/api/admin/users/{userId}", userId)).andExpect(status().isOk());
}

@Test
@WithMockUser(roles = "ADMIN")
void shouldApprovePendingUser() throws Exception {
String userId = pendingUser.getId();
AppUser approvedUser = pendingUser;
approvedUser.setRole(UserRole.RESIDENT);

when(userService.approvePendingUser(userId)).thenReturn(approvedUser);
when(userMapper.toResponse(any(AppUser.class))).thenReturn(null);

mockMvc.perform(post("/api/admin/users/{userId}/approve", userId)).andExpect(status().isOk());
}

@Test
@WithMockUser(roles = "ADMIN")
void shouldUpdateUserRole() throws Exception {
String userId = testUser.getId();
String requestBody = "{\"role\":\"ADMIN\"}";
AppUser updatedUser = testUser;
updatedUser.setRole(UserRole.ADMIN);

when(userService.getUserById(userId)).thenReturn(testUser);
when(userService.getAllUsers()).thenReturn(Arrays.asList(testUser, updatedUser));
when(userService.updateUserRole(userId, UserRole.ADMIN)).thenReturn(updatedUser);
when(userMapper.toResponse(any(AppUser.class))).thenReturn(null);

mockMvc.perform(patch("/api/admin/users/{userId}/role", userId).contentType(MediaType.APPLICATION_JSON)
.content(requestBody)).andExpect(status().isOk());
}

@Test
@WithMockUser(roles = "ADMIN")
void shouldUpdateUserStatus() throws Exception {
String userId = testUser.getId();
String requestBody = "{\"active\":false}";
AppUser updatedUser = testUser;
updatedUser.setActive(false);

when(userService.updateUserActiveStatus(userId, false)).thenReturn(updatedUser);
when(userMapper.toResponse(any(AppUser.class))).thenReturn(null);

mockMvc.perform(patch("/api/admin/users/{userId}/status", userId).contentType(MediaType.APPLICATION_JSON)
.content(requestBody)).andExpect(status().isOk());
}

@Test
@WithMockUser(roles = "ADMIN")
void shouldDeleteUser() throws Exception {
String userId = testUser.getId();

when(userService.getUserById(userId)).thenReturn(testUser);
doNothing().when(userService).deleteUser(userId);

mockMvc.perform(delete("/api/admin/users/{userId}", userId)).andExpect(status().isNoContent());

verify(userService).deleteUser(userId);
}

@Test
@WithMockUser(roles = "ADMIN")
void shouldGetStats() throws Exception {
List<AppUser> allUsers = Arrays.asList(testUser, pendingUser, handlerUser);
List<AppUser> pendingUsers = Arrays.asList(pendingUser);
List<AppUser> residents = Arrays.asList(testUser);
List<AppUser> handlers = Arrays.asList(handlerUser);
List<AppUser> admins = Arrays.asList();

when(userService.getAllUsers()).thenReturn(allUsers);
when(userService.getUsersByRole(UserRole.PENDING)).thenReturn(pendingUsers);
when(userService.getUsersByRole(UserRole.RESIDENT)).thenReturn(residents);
when(userService.getUsersByRole(UserRole.HANDLER)).thenReturn(handlers);
when(userService.getUsersByRole(UserRole.ADMIN)).thenReturn(admins);

mockMvc.perform(get("/api/admin/stats")).andExpect(status().isOk()).andExpect(jsonPath("$.totalUsers").value(3))
.andExpect(jsonPath("$.pendingUsers").value(1)).andExpect(jsonPath("$.residents").value(1))
.andExpect(jsonPath("$.handlers").value(1)).andExpect(jsonPath("$.admins").value(0));
}
}
Loading