Skip to content

fix: use requestSubmit() to preserve HTML5 form validation #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apaegs merged 3 commits into from
Apr 27, 2026
Merged

fix: use requestSubmit() to preserve HTML5 form validation #135

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00d219d
fix: use requestSubmit() to preserve HTML5 form validation
viktorlindell12 Apr 27, 2026
f7bfdd1
Merge remote-tracking branch 'origin/main' into fix/form-request-submit
viktorlindell12 Apr 27, 2026
9aed042
Fix null form reference and stop form submit on upload failure
viktorlindell12 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions src/main/resources/static/js/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,23 +24,27 @@ async function downloadFile(fileName) {

async function uploadNewFile(){
const submitBtn = document.getElementById('submitBtn');
submitBtn.disabled = true;
const form = submitBtn?.form ?? document.querySelector('form');
if (submitBtn) submitBtn.disabled = true;
const input = document.getElementById('fileInput');
const status = document.getElementById('status');
if (input.files.length === 0){
document.querySelector('form').submit();
if (form) form.requestSubmit();
return;
}
const filesToUpload = Array.from(input.files);
input.value = null;
submitBtn.innerText = "Uploading...";
if (submitBtn) submitBtn.innerText = "Uploading...";
for (let i = 0; i < filesToUpload.length; i++) {
const file = filesToUpload[i];

try {
status.innerText = `Processing file ${i + 1} of ${filesToUpload.length}: ${file.name}`;
const res = await apiReq(`/tickets/upload/api/files/upload-url?fileName=${encodeURIComponent(file.name)}&contentType=${encodeURIComponent(file.type)}`);
if (!res) continue;
if (!res) {
if (submitBtn) { submitBtn.disabled = false; submitBtn.innerText = "Create Ticket"; }
return;
}
const { url, fileName: uploadedFileName } = await res.json();
status.innerText = `Uploading ${file.name}...`;
const putRes = await fetch(url, {
Expand All @@ -63,20 +67,19 @@ async function uploadNewFile(){
hiddenContainer.appendChild(input);
} else {
status.innerText = `Failed to upload ${file.name}. Status: ${putRes.status}`;
submitBtn.disabled = false;
submitBtn.innerText = "Create Ticket";
if (submitBtn) { submitBtn.disabled = false; submitBtn.innerText = "Create Ticket"; }
return;
}
} catch (error) {
console.error(error);
status.innerText = `Error uploading ${file.name}: ${error.message}`;
submitBtn.disabled = false;
submitBtn.innerText = "Create Ticket";
if (submitBtn) { submitBtn.disabled = false; submitBtn.innerText = "Create Ticket"; }
return;
}
}
submitBtn.disabled = false;
submitBtn.innerText = "Create Ticket";
if (submitBtn) { submitBtn.disabled = false; submitBtn.innerText = "Create Ticket"; }
status.innerText = "All uploads completed.";
document.querySelector('form').submit();
if (form) form.requestSubmit();
}

async function deleteFile(fileName){
Expand Down