-
Notifications
You must be signed in to change notification settings - Fork 1
fix: preserve SavedRequest in auth success handler and fix deleteFile… #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
95a17a1
fix: preserve SavedRequest in auth success handler and fix deleteFile…
viktorlindell12 e93db1d
merge main and resolve script.js conflict
viktorlindell12 430a556
fix: correct S3 API URL prefix and add null guard in deleteFile
viktorlindell12 d272085
merge origin/main and resolve script.js conflict
viktorlindell12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
src/main/java/org/example/untitled/security/CustomAuthenticationSuccessHandler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package org.example.untitled.security; | ||
|
|
||
| import jakarta.servlet.ServletException; | ||
| import jakarta.servlet.http.HttpServletRequest; | ||
| import jakarta.servlet.http.HttpServletResponse; | ||
| import org.example.untitled.user.Role; | ||
| import org.springframework.security.core.Authentication; | ||
| import org.springframework.security.web.authentication.SavedRequestAwareAuthenticationSuccessHandler; | ||
| import org.springframework.security.web.savedrequest.HttpSessionRequestCache; | ||
| import org.springframework.security.web.savedrequest.SavedRequest; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Optional; | ||
|
|
||
| public class CustomAuthenticationSuccessHandler extends SavedRequestAwareAuthenticationSuccessHandler { | ||
|
|
||
| private final HttpSessionRequestCache requestCache = new HttpSessionRequestCache(); | ||
|
|
||
| @Override | ||
| public void onAuthenticationSuccess(HttpServletRequest request, HttpServletResponse response, | ||
| Authentication authentication) throws IOException, ServletException { | ||
| SavedRequest savedRequest = requestCache.getRequest(request, response); | ||
| if (savedRequest != null) { | ||
| super.onAuthenticationSuccess(request, response, authentication); | ||
| return; | ||
| } | ||
|
|
||
| Role role = authentication.getAuthorities().stream() | ||
| .map(a -> Role.fromAuthority(a.getAuthority())) | ||
| .flatMap(Optional::stream) | ||
| .findFirst() | ||
| .orElse(Role.USER); | ||
|
|
||
| String targetUrl = switch (role) { | ||
| case ADMIN -> "/admin"; | ||
| case HANDLER, SUPERVISOR -> "/handler"; | ||
| default -> "/user"; | ||
| }; | ||
|
|
||
| clearAuthenticationAttributes(request); | ||
| getRedirectStrategy().sendRedirect(request, response, targetUrl); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.