Skip to content

Removed delete-functionality for patients#93

Merged
LinusWestling merged 2 commits into
mainfrom
feature/patientDelete
Apr 23, 2026
Merged

Removed delete-functionality for patients#93
LinusWestling merged 2 commits into
mainfrom
feature/patientDelete

Conversation

@LinusWestling

@LinusWestling LinusWestling commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Revert
    • Patient deletion functionality has been removed from the application. The delete action is no longer available in the patient list, and all patient deletion endpoints have been discontinued across the web interface and API.

@coderabbitai

coderabbitai Bot commented Apr 23, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@LinusWestling has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 51 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 51 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f6846c79-3605-4fc9-8e6d-d8b36e24ac6d

📥 Commits

Reviewing files that changed from the base of the PR and between 6fa6b86 and e797a93.

📒 Files selected for processing (3)
  • src/test/java/org/example/projektarendehantering/application/service/PatientServiceTest.java
  • src/test/java/org/example/projektarendehantering/presentation/rest/PatientControllerTest.java
  • src/test/java/org/example/projektarendehantering/presentation/web/PatientUiControllerTest.java
📝 Walkthrough

Walkthrough

The patient deletion feature is being completely removed from the application across all layers: service logic, REST and UI controllers, HTML template, and all associated test coverage. This includes the deletePatient() methods and their corresponding endpoints and tests.

Changes

Cohort / File(s) Summary
Service Layer
PatientService.java
Removed deletePatient(Actor actor, UUID id) method and all associated authorization, validation, and repository deletion logic.
Controller Layer
PatientController.java, PatientUiController.java
Removed HTTP DELETE endpoint (/{id}) from REST controller and POST delete endpoint (/ui/patients/delete/{id}) from UI controller, including @PreAuthorize role checks.
UI Template
patients/list.html
Removed delete action button and form submission logic from the patient list view; only "Edit" link remains.
Test Coverage
PatientServiceTest.java, PatientControllerTest.java, PatientUiControllerTest.java
Removed all test methods covering patient deletion functionality across service, REST, and UI layers (42 lines total removed).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • #75 crud for patients and users #76: Directly related — adds the public deletePatient(Actor, UUID) service method and corresponding REST/UI DELETE endpoints and tests that are being removed in this PR.

Poem

🐰 A hop and a skip, the delete is gone,
No more patient removals from dusk until dawn,
The templates cleaned, the tests swept away,
Simpler and lighter, a cleaner display!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and concisely describes the main change: removal of patient deletion functionality across all layers (service, REST, UI controllers, templates, and tests).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/patientDelete

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LinusWestling
LinusWestling merged commit ecf2fbc into main Apr 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant