Skip to content

fix: add default values to GitHub and S3 credentials placeholders#105

Merged
LinusWestling merged 2 commits into
mainfrom
fix/oauth-placeholders
Apr 24, 2026
Merged

fix: add default values to GitHub and S3 credentials placeholders#105
LinusWestling merged 2 commits into
mainfrom
fix/oauth-placeholders

Conversation

@Tyreviel

@Tyreviel Tyreviel commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

#104

Summary by CodeRabbit

  • Chores
    • Updated default configuration fallback values for GitHub OAuth and cloud storage authentication to streamline initial deployment setup without immediate credential provisioning.

@coderabbitai

coderabbitai Bot commented Apr 24, 2026

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Updated default fallback values in application.properties for OAuth GitHub credentials (GITHUB_CLIENT_ID/GITHUB_CLIENT_SECRET now default to none) and S3 credentials (S3_ACCESS_KEY/S3_SECRET_KEY now default to minioadmin).

Changes

Cohort / File(s) Summary
Configuration Defaults
src/main/resources/application.properties
Updated placeholder defaults: GitHub credentials fall back to none, S3 credentials fall back to minioadmin when environment variables are unset.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through configs bright,
Where secrets hide and keys take flight,
GitHub says "none," S3 says "mini,"
Defaults dance, both clean and skinny! 🔑

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding default values to GitHub and S3 credential placeholders in the configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/oauth-placeholders

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LinusWestling
LinusWestling merged commit 8456fd6 into main Apr 24, 2026
1 check passed
@Tyreviel
Tyreviel deleted the fix/oauth-placeholders branch April 24, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants