fix(security): implement missing access controls on withdrawTokens and initConfig#426
Open
anzzyspeaksgit wants to merge 1 commit into
Open
fix(security): implement missing access controls on withdrawTokens and initConfig#426anzzyspeaksgit wants to merge 1 commit into
anzzyspeaksgit wants to merge 1 commit into
Conversation
…initConfig (ithacaxyz#420) - Added `Ownable` and `onlyOwner` modifier to `Orchestrator.withdrawTokens` to prevent unauthorized sweeping of accumulated fees/tokens - Gated `MultiSigSigner.initConfig` so that only the EOA key (`contextKeyHash == bytes32(0)`) or super-admin keys can initialize the config, preventing front-running attacks Closes ithacaxyz#420
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As reported in #420, two high severity security issues were identified:
Orchestrator.withdrawTokenshad no access controls, allowing anyone to sweep tokens from the orchestrator.MultiSigSigner.initConfigbypassed_checkKeyHash, allowing a session key to front-run the legitimate owner, initialize a malicious super-admin multisig config, and permanently lock it.Solution
solady/auth/Ownable.sol, addedOwnableinheritance, initialized the owner in a newconstructor()(assigned tomsg.sender), and added theonlyOwnermodifier towithdrawTokens(similar toSimpleFunder).initConfigto ensure that only the EOA key (contextKeyHash == bytes32(0)) or an authorized super-admin key (verified viaIthacaAccount.getKey) can initialize the multisig configurations.Closes #420