Write dump files to /tmp and clean them up after upload#26
Open
n1mmy wants to merge 2 commits into
Open
Conversation
That way I can mount a bigger volume there.
Remove existing dump files before creating new backups. In case volume is persistent and there are failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small, related changes to
backup.sh:/tmpfor the intermediate dump file (commit 1) instead of the container's working directory. This makes it easy to mount a larger volume at/tmpfor databases whose dump exceeds the default container filesystem./tmpvolume) don't accumulate stale dumps. Also adds defensiverm -fbefore each new dump in case a previous run failed before reaching the post-upload cleanup.Changes
backup.sh: changeSRC_FILEfromdump.dump/dump.sql.gzto/tmp/dump.dump//tmp/dump.sql.gzbackup.sh:rm -f $SRC_FILEafter the upload, and defensively before each dump invocation