Add POSTGRES_EXTRA_DUMP_OPTS for extra pg_dump arguments#25
Open
n1mmy wants to merge 1 commit into
Open
Conversation
Allows passing dump-specific flags such as --exclude-table without affecting the connection options reused by psql/pg_restore. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
POSTGRES_EXTRA_DUMP_OPTSenvironment variable that is passed through topg_dump/pg_dumpallinvocations inbackup.sh. This allows passing dump-specific flags such as--exclude-table=public.fooor--exclude-table-data=public.sessionswithout affecting connection-level options.Why a separate variable from
POSTGRES_EXTRA_OPTS?POSTGRES_EXTRA_OPTSalready feeds intoPOSTGRES_HOST_OPTS, which is reused bypsql/pg_restoreinrestore.sh. Dump-only flags like--exclude-tablewould break those callers, so they need their own variable.Changes
Dockerfile: declarePOSTGRES_EXTRA_DUMP_OPTSwith empty defaultbackup.sh: thread$POSTGRES_EXTRA_DUMP_OPTSinto all three dump invocations (custom format,pg_dumpall, plainpg_dump)README.md: document the new variableExample
docker run ... -e POSTGRES_EXTRA_DUMP_OPTS="--exclude-table=public.audit_log" ...