💄 introduce sass #306 - #307
Conversation
|
Currently only as an example |
|
@FabianWilms I think we need to discuss the file structure here. Formating of the fontface-css files should not be done. |
I think this goes for all files coming from MDE directly - so everything in the temp-directory? |
Definitely |
We currently have manual files in the temp directory :D that is the problem I want to adress |
Which idiot thought this was a good idea? Yeah we should definitely move them one folder up. This would sadly require a breaking change release. |
It is what it is ... no seperate folder just one up? I don't know who is meant by this but I certainly don't think he/she is an idiot ;) |
I'm open to suggestions and don't really have a preferred opinion. A new folder could be more organized but might never contain more files. You decide! |
…irectory This change requires users of the lib to fix their imports. Please refer to the 'Getting Started' section for the new way to import the required assets.
|
@langehm I reworked the way we import MDE assets and moved our own assets away from the From here on you can continue to implement the SASS-enhancement. If you're really fancy you can combine all our "custom" css files into one in our build, so we're no longer required to import our two custom css-files seperately. |
# Conflicts: # .storybook/preview.ts # docs/GettingStarted.mdx # package-lock.json # package.json # public/assets/css/custom-style.css # src/components/Card/MucCard.vue
|
scss is working for now. Should we convert all of the stylings in this pr too? @FabianWilms |
You mean |
yes and no. I meant every use of a custom class or style inside the components if possible to some generated class of the scss. |
|
Sorry I misunderstood your question at first. Yes that would be great to have it consistent! |
# Conflicts: # package-lock.json # package.json
Description
Reference
Issues #306