Fix CSA adaptive bank growth reference sync#48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CSA adaptive bank growth can append entries after the reference bank has already been initialized. The previous boundary sync treated
len(reference_bank.entries) == len(bank.entries)as the initialization check, so an adaptive append made the active bank longer than the reference bank and caused the reference bank to be rebuilt from the active bank.This change gives
ReferenceBankan explicit initialization state and uses that state at the boundary sync. Once the first complete reference snapshot exists, adaptive growth no longer re-sorts or rebuilds it just because the active bank grew.Impact
Fixes #25
Validation
uv run --python 3.11 --extra test pytest tests -quv run --python 3.11 --extra test ruff check pyproject.toml src testsuv run --python 3.11 --extra test basedpyright src testsgit diff --cached --check