Enforce hard evaluation budgets and checkpoint-safe runs#46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes evaluation budgeting strict by default.
Study.run(...)andStudy.optimize(...)now chargemax_evaluationsagainst reported logical evaluation cost, including local-search inner evaluations, rather than only counting returned records. Callers that want the old outer-record behavior can still passcount_evaluation_cost=False.It also adds
stop_at_checkpoint_boundary=Trueso CSA runs can return the latest checkpoint-safe state when the budget ends inside an unsafe generation segment. Structured and SciPy local-search kernels now reserve enough budget for later proposals in the same batch before spending extra local-search evaluations.User impact
This is a behavior change for code that relied on the old default budget accounting. Over-budget reported evaluation cost now raises
EvaluationBudgetExhaustedinstead of silently assimilating an over-budget step. The changelog and local-optimization/checkpointing docs call out the migration path.Validation
uv run --python 3.11 --extra test ruff check pyproject.toml src testsuv run --python 3.11 --extra test basedpyright src testsuv run --python 3.11 --extra test pytest tests -qmypy src/varioptstill reports the existing scipy/joblib missing-stub errors only; the branch-introduced kernel error is gone.