Skip to content

not failing in module scope when run in node #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antialias wants to merge 1 commit into
base: master
Choose a base branch
from
Open

not failing in module scope when run in node #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ import { create } from './create'
import { run } from './run'

const createWrapper = () => {
if ('undefined' === typeof window) {

@israelss israelss Aug 22, 2021

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any particular reason for use undefined on the left side. If not, can you please invert this order?

return null;

@israelss israelss Aug 22, 2021

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add some return to the user, if not an console.error at least a console.log

}
if (!window.Worker) {
console.error('This browser does not support Workers.')
return null
Expand Down