[FIX] items in ParentCache can be cleared by callback twice#960
Open
PatrykWalach wants to merge 2 commits into
Open
[FIX] items in ParentCache can be cleared by callback twice#960PatrykWalach wants to merge 2 commits into
ParentCache can be cleared by callback twice#960PatrykWalach wants to merge 2 commits into
Conversation
|
Related Documentation No published documentation to review for changes on this repository. Write your first living document How did I do? Any feedback? |
PatrykWalach
force-pushed
the
cache-item-bug
branch
from
0bc3647 to
6a46c49
Compare
PatrykWalach
changed the title
ParentCache can be cleared by callback twice
PatrykWalach
changed the title
ParentCache can be cleared by callback twiceParentCache can be cleared by callback twice
PatrykWalach
changed the title
ParentCache can be cleared by callback twiceParentCache can be cleared by callback twice
PatrykWalach
commented
Mar 5, 2026
|
|
||
| expect(() => { | ||
| disposeTemporaryRetain(); | ||
| }).toThrow(); |
Member
Author
There was a problem hiding this comment.
In this test it would throw A temporary retain was cleared, for which the CacheItem is in an invalid state. but at runtime it was possible to go into a different branch and cause issues (temporary retain count could have been decremented more than once).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.