Skip to content

Beta match SpheresIntersect#1745

Merged
disinvite merged 2 commits into
isledecomp:masterfrom
disinvite:spheres-intersect
Feb 15, 2026
Merged

Beta match SpheresIntersect#1745
disinvite merged 2 commits into
isledecomp:masterfrom
disinvite:spheres-intersect

Conversation

@disinvite

Copy link
Copy Markdown
Collaborator

This is the second function degraded by the change to effective matching in isledecomp/reccmp#323. The diff is:

mov esi, dword ptr [eax + 4]
+fld dword ptr [esi + 4]
+mov edx, dword ptr [ecx + 4]
+fsub dword ptr [edx + 4]
fld dword ptr [esi + 8]
-mov edx, dword ptr [ecx + 4]
fsub dword ptr [edx + 8]
-fld dword ptr [esi + 4]
-fsub dword ptr [edx + 4]

This should be an effective match, but I thought I could force 100% by matching the beta. No luck there.

WriteDefaultTexture dropped a bit in this PR, but scored 89.45% for me with 256 entropy samples.

SpheresIntersect is a non-effective 100% match in the latest entropy build.

I also added a few other beta addresses I spotted while reviewing this.

@disinvite disinvite merged commit 2740065 into isledecomp:master Feb 15, 2026
12 checks passed
@disinvite disinvite deleted the spheres-intersect branch February 15, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants