Beta match SpheresIntersect#1745
Merged
Merged
Conversation
foxtacles
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second function degraded by the change to effective matching in isledecomp/reccmp#323. The diff is:
This should be an effective match, but I thought I could force 100% by matching the beta. No luck there.
WriteDefaultTexturedropped a bit in this PR, but scored 89.45% for me with 256 entropy samples.SpheresIntersectis a non-effective 100% match in the latest entropy build.I also added a few other beta addresses I spotted while reviewing this.