Modernize codebase with Svelte 5 features#43
Merged
Merged
Conversation
I've been using amp to produce refactorings in a bunch of the subsequent commits. Threads will be linked in commit messages.
Amp helped me with a few tricky `run`s inserted by the svelte migrator. https://ampcode.com/threads/T-019cb7b5-c93f-7189-b527-42977e79d772
Amp guided me on what to do with Preferences: https://ampcode.com/threads/T-019cb7d2-5d11-730b-9174-50c362be1eb9
This is the same that we do for `files` and `matches`, which are most analogous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to runes, and eliminate usage of stores. Plus, a few minor improvements to syntax highlighting. Some things in here were done with LLM assistance; there is a link to an amp thread for all such cases.