arch audit safe cleanup - #110
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
- Coverage 94.98% 94.96% -0.02%
==========================================
Files 27 27
Lines 20805 20708 -97
==========================================
- Hits 19762 19666 -96
+ Misses 1043 1042 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
Author
|
@copilot review |
Review found one high-severity issue: the PR removes multiple public APIs while |
Owner
Author
|
@claude[agent] review |
Reviewed. The only valid finding was the missing version bump for the removed public APIs. Bumped the workspace version 0.8.1 → 0.9.0 (including the pinned Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
isdaniel
force-pushed
the
refactor/arch-audit-safe-cleanup
branch
3 times, most recently
from
July 27, 2026 06:00
233635f to
76efde0
Compare
… functions refactor: remove unused methods and streamline BufferReader and BufferWriter implementations refactor(error): eliminate generic error type and related methods for clarity refactor(lib): adjust visibility of PG_EPOCH_OFFSET_SECS constant refactor(lsn): simplify SharedLsnFeedback by removing Clone implementation and related tests refactor(sql_builder): change build_sql_options to crate visibility fix(stream): update error handling to use protocol-specific error type refactor(types): update CachePadded and PG_EPOCH_OFFSET_SECS to crate visibility
isdaniel
force-pushed
the
refactor/arch-audit-safe-cleanup
branch
from
July 27, 2026 06:27
76efde0 to
dfcc0c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
postgres_timestamp_to_chronono longer panics on a corrupt/adversarialtimestamp on the live BEGIN/COMMIT parse path (saturating + euclidean + clamp).
prepare_*wrappers (addprepare_base_backup).synfullfeature; misc doc fixes.Breaking — public API
ReplicationError::{Generic, generic(), replication_connection()}(use
connection());impl Clone for SharedLsnFeedback(share viaArc, not adetached copy); ~18 unused
BufferReader/BufferWritermethods(
from_vec/read_i16/read_string/skip, most writer variants,Default/AsRef).CachePadded,PG_EPOCH_OFFSET_SECS(also dropped from thecrate root re-export),
build_sql_options→pub(crate).ChangeEvent::encode/decode— a bespoke binary codecredundant with the derived
serdeimpls; use serde + bincode/postcard. It is NOT thepgoutput wire format (that lives in
protocol/encode_message, untouched). Removalplanned for a future major.