Skip to content

fix(badges): médaillons ×N / ÷N lisibles et cohérents (fin des emojis) #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isc merged 2 commits into from
Jul 1, 2026
Merged

fix(badges): médaillons ×N / ÷N lisibles et cohérents (fin des emojis) #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ee2aea
fix(badges): médaillons de division lisibles (÷N blanc au lieu de l'e…
isc Jul 1, 2026
e772a5f
fix(badges): médaillons de multiplication en ×N, cohérents avec ÷N
isc Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/BadgeDetailModal.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
align-items: center;
justify-content: center;
color: #fff;
font-family: var(--serif);
font-weight: 700;
font-size: 38px;
margin: 4px auto 14px;
box-shadow: inset 0 -3px 0 rgba(0, 0, 0, 0.12);
Expand Down
12 changes: 10 additions & 2 deletions src/lib/badges.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,10 @@ function buildAllBadgeDefinitions(): BadgeDefinition[] {
return {
id: `${BADGE_IDS.TABLE_PREFIX}${n}`,
...i.table(n),
icon: `${n}️⃣`,
// Glyphe texte « ×N » blanc serif, cohérent avec les badges de
// division « ÷N » : plutôt que le keycap emoji ${n}️⃣ (sticker coloré
// qui jurait à côté des médaillons de division épurés).
icon: `×${n}`,
color: 'var(--indigo)',
progressFor: (p: UserProfile) => {
const tableFacts = factsForTable(p.facts, n);
Expand Down Expand Up @@ -236,7 +239,12 @@ function buildDivisionBadgeDefinitions(): BadgeDefinition[] {
return {
id: `${BADGE_IDS.DIV_TABLE_PREFIX}${n}`,
...i.divTable(n),
icon: '➗',
// Glyphe texte « ÷N » (rendu blanc serif par .badge-medallion) plutôt
// que l'emoji ➗ : sur iOS celui-ci s'affiche en sombre — quasi noir sur
// le médaillon indigo (#4F46BA) — et les 8 badges étaient tous
// identiques. « ÷2 »… « ÷9 » les rend lisibles ET distincts, en miroir
// des badges multiplication numérotés.
icon: `÷${n}`,
color: 'var(--indigo)',
progressFor: (p: UserProfile) => {
const tableFacts = factsForDivisionTable(p.divisionFacts ?? [], n);
Expand Down
Loading