Remove deprecated Elasticsearch query framework#794
Draft
axlewin wants to merge 25 commits into
Draft
Conversation
This endpoint has been unsupported for over a year, and for two months has been inaccessible in production (since 3d839bf). Several deprecated methods were required for it to work, and without it these too can be removed. This gets rid of at least one more deprecated ES method. Since we no longer generate random gameboards, we no longer have any need to store temporary boards. The cache can be removed too, but for now I have just removed the "store new temporary board" method.
No longer needed since all of its methods are superseded by AbstractInstruction-based equivalents
and convertToBoolMap helper method
Deprecated; AbstractFilterInstruction-based searching should use AbstractInstructions instead
Deprecated; AbstractFilterInstruction-based searching should use AbstractInstructions instead
This is superseded by buildBaseInstructions, which is easier to work with for AbstractInstructions (as opposed to AbstractFilterInstructions).
Also remove the tests for the removed methods. These all used AbstractFilterInstructions. Going forward, AbstractInstruction-based searching should be used instead.
Deprecated in favour of BooleanInstructions
To allow e.g. nofilter quizzes to be viewed. If nofilter content needs to be excluded based on role, this should be handled outside of this manager (e.g. in QuizManager).
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
+ Coverage 40.31% 40.36% +0.05%
==========================================
Files 547 541 -6
Lines 23773 23394 -379
Branches 2893 2833 -60
==========================================
- Hits 9584 9444 -140
+ Misses 13288 13083 -205
+ Partials 901 867 -34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The "should" clauses should be grouped together and nested in a parent "must" to ensure at least one clause per group is satisfied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all usage of
BooleanSearchClauseandAbstractFilterInstruction-based searching in favour of the newerAbstractInstruction-based pattern. This removes a lot of duplicated logic; there should now be a single, consistent approach to building ES queries across the whole project. In the vast majority of cases, searches should now use a singleBooleanInstructioninstead of calling various helper methods.Also removes the
generateTemporaryGameboardendpoint, which has been unsupported for over a year. This change is technically unrelated but was needed in order to remove some of the ES framework.