Skip to content

Add triangular lattice topology and subset generation - #61

Open
Ferrari-72 wants to merge 6 commits into
isPANN:mainfrom
Ferrari-72:pr2-triangular-lattice-topology
Open

Add triangular lattice topology and subset generation#61
Ferrari-72 wants to merge 6 commits into
isPANN:mainfrom
Ferrari-72:pr2-triangular-lattice-topology

Conversation

@Ferrari-72

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Mar 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.95238% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/graphio/udg.jl 80.95% 16 Missing ⚠️
Files with missing lines Coverage Δ
src/graphio/udg.jl 57.83% <80.95%> (+20.80%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

isPANN and others added 5 commits March 16, 2026 23:50
Generate pr2 lattice boundary pins in left-top-right-bottom order so triangular UDG datasets match the fixed boundary-role semantics used by the crossing search.
Exercise the triangular plotting example and the new triangular UDG validation branches so the PR covers more of the lattice-topology diff on CI.
Move dedup strategy decisions to the entry point, require shortg explicitly when requested, and add g6 fallback plus strict-dedup behavior tests to prevent silent degradation.

Made-with: Cursor
@Ferrari-72

Copy link
Copy Markdown
Contributor Author

What changed

  1. Move strategy decisions to the top level
    • Dedup strategy selection is now centralized in generate_triangular_udg_subsets (entry point).
    • dedup_inner_subsets now focuses on executing the selected strategy, instead of making implicit fallback decisions.
  2. Fail fast instead of silent fallback
    • dedup_inner_subsets(...; use_shortg=true) now throws ArgumentError if shortg is unavailable.
    • Added strict_dedup; in strict mode, unmet prerequisites fail immediately.
  3. Explicit fallback behavior
    • At the entry point, if shortg is unavailable, we explicitly fall back to g6-string dedup with a warning.
    • This prevents “deduplication appears enabled but is effectively skipped” behavior.

Test improvements

  • Added tests for strict_dedup argument constraints.
  • Added tests for the use_shortg=true + missing shortg failure path.
  • Added behavior tests comparing raw vs deduplicated outputs (count + structure assertions).

Validation

  • julia --project test/graphio/udg.jl passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants