Grant RBAC for events in events.k8s.io API group#735
Conversation
The machinepoollet (linked from ironcore) and any reconciler that uses
controller-runtime v0.23+ now emits events through the new EventRecorder
which writes to the events.k8s.io/v1 API. Without this rule the apiserver
rejects every event with:
events.events.k8s.io "..." is forbidden: User
"system:serviceaccount:libvirt-provider:libvirt-provider-controller-manager"
cannot patch resource "events" in API group "events.k8s.io"
Mirror what controller-gen produces in ironcore upstream by listing both
API groups ("" and events.k8s.io) on the existing events rule.
Signed-off-by: Felix Riegger <felix.riegger@sap.com>
1fcbe4c to
6d8fcbe
Compare
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The machinepoollet (linked from ironcore) and any reconciler that uses controller-runtime v0.23+ now emits events through the new EventRecorder which writes to the events.k8s.io/v1 API. Without this rule the apiserver rejects every event with:
events.events.k8s.io "..." is forbidden: User
"system:serviceaccount:libvirt-provider:libvirt-provider-controller-manager"
cannot patch resource "events" in API group "events.k8s.io"
Mirror what controller-gen produces in ironcore upstream by listing both API groups ("" and events.k8s.io) on the existing events rule.