fix: add e2e tests for downloading over WS/WSS/WebTransport - #1097
Draft
aschmahmann wants to merge 7 commits into
Draft
fix: add e2e tests for downloading over WS/WSS/WebTransport#1097aschmahmann wants to merge 7 commits into
aschmahmann wants to merge 7 commits into
Conversation
aschmahmann
force-pushed
the
fix/e2e-testing
branch
from
May 28, 2026 12:58
ce9186b to
6ced956
Compare
aschmahmann
commented
May 28, 2026
achingbrain
reviewed
May 28, 2026
achingbrain
reviewed
May 28, 2026
achingbrain
reviewed
May 28, 2026
aschmahmann
force-pushed
the
fix/e2e-testing
branch
2 times, most recently
from
May 28, 2026 18:51
4b8565e to
834e01e
Compare
aschmahmann
force-pushed
the
fix/e2e-testing
branch
from
May 28, 2026 19:18
834e01e to
2cf4629
Compare
dionatasv42-del
approved these changes
May 29, 2026
dionatasv42-del
approved these changes
May 29, 2026
dionatasv42-del
approved these changes
May 29, 2026
3 tasks
aschmahmann
commented
May 29, 2026
| */ | ||
| async function mockRouting (page: any, peerAddrs: string[]): Promise<void> { | ||
| await page.route( | ||
| `${MAIN_KUBO}/routing/v1/providers/**`, |
Contributor
Author
There was a problem hiding this comment.
@achingbrain should we also block the routing/v1/peers endpoint to prevent discovering additional addresses for the peer and circumventing the test or does Helia not do this?
Member
There was a problem hiding this comment.
Makes sense for a belt & braces approach.
js-libp2p will query the routing if the peer to dial has no known addresses so I think we are ok for now but I think there was some talk about querying if the dial fails.
aschmahmann
marked this pull request as ready for review
May 29, 2026 12:47
3 tasks
- switch mocks from page to page.context - mock out peer routing in bitswap tests
5 tasks
achingbrain
added a commit
to ipfs/helia
that referenced
this pull request
May 31, 2026
When a peer has HTTP multiaddrs, ensure that the matching doesn't eagerly also match WS(S) addresses. Refs: ipfs/service-worker-gateway#1092 Refs: ipfs/service-worker-gateway#1097
lidel
marked this pull request as draft
June 9, 2026 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
fix: add e2e tests for downloading over WS/WSS/WebTransport
Description
There have been regressions related to downloading from WS/WSS/WebTranport addresses. We add tests here to catch them as well as associated fixes.
Notes & open questions
Change checklist