fix: support inspecting hamt shards - #1014
Draft
achingbrain wants to merge 4 commits into
Draft
Conversation
When a path results in a 404, retry without HAMT translation
achingbrain
marked this pull request as draft
March 25, 2026 15:50
achingbrain
commented
Mar 30, 2026
| response = await verifiedFetch(resource, init) | ||
|
|
||
| // special case - if the user is trying to preview HAMT sub-shards | ||
| if (response.status === 404) { |
Member
Author
There was a problem hiding this comment.
This is expensive, a better solution would be for verified fetch to either somehow signal that the root CID was a HAMT shard so the translateHAMTPath option is available, or to add a new query string param to the service worker gateway that lets the user express their intention and set translateHAMTPath explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a path results in a 404, retry without HAMT translation
Refs: #1066
Change checklist