fix: clear firefox amo submission warnings#1388
Merged
Merged
Conversation
AMO flagged v3.4.0 for a missing data_collection_permissions key and for referencing declarativeNetRequest APIs below their supported Firefox version. - declare no data collection with required ["none"] - raise strict_min_version to 113, where the declarativeNetRequest namespace (getDynamicRules) becomes available
lidel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Submitting the v3.4.0 Firefox build to addons.mozilla.org raised validator warnings. The required
data_collection_permissionskey was missing1, andstrict_min_versionwas 111, below Firefox 113 where thedeclarativeNetRequestAPIs the bundle references first exist.Fix
data_collection_permissions.requiredset to["none"], matching our no-tracking privacy policystrict_min_versionto 113, the floor for thedeclarativeNetRequestnamespace (getDynamicRules)innerHTMLis safe, since addons-linter keeps flagging itThe 113 bump drops Firefox 111-112 (March-April 2023); those
declarativeNetRequestpaths never run on Firefox anyway, which useswebRequestBlocking. Two validator warnings remain and are expected: the consent key is only recognized in Firefox 140+, so a lower min version draws an informational note and older Firefox ignores the key. TheinnerHTMLwarnings also remain by design; their input is our own bundled translations, and the code now says so inline.Footnotes
Firefox built-in data consent: the key is required for new extensions and, in future, new versions of existing ones. ↩