Skip to content

fix: ESLint Rules #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whizzzkid wants to merge 3 commits into from
Closed

fix: ESLint Rules #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2f731d
fix: :rotating_light: fix line length
whizzzkid Feb 5, 2023
5f041ca
fix: :rotating_light: Fix redundant return awaits except try-catch
whizzzkid Feb 5, 2023
dd5b3f3
fix: :rotating_light: yield-star-spacing
whizzzkid Feb 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions js.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,14 @@ module.exports = {
'no-implicit-coercion': 'error',
'no-loop-func': 'error',
'no-nested-ternary': 'warn',
'no-return-await': 'off',
'no-script-url': 'error',
'no-warning-comments': 'warn',
'max-nested-callbacks': ['error', 4],
'max-depth': ['error', 4],
'max-len': ['error', 120],
'require-yield': 'error',
'yield-star-spacing': ['error', 'after'],
// plugins
'no-only-tests/no-only-tests': 'error',
'jsdoc/check-alignment': 'error',
Expand Down
5 changes: 3 additions & 2 deletions ts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@ module.exports = {
rules: {
'no-use-before-define': 'off', // Types often are recursive & no use before define is too restrictive
'etc/prefer-interface': 'error', // https://ncjamieson.com/prefer-interfaces/
'@typescript-eslint/prefer-function-type': 'off', // conflicts with 'etc/prefer-interface'
'@typescript-eslint/await-thenable': 'error', // disallows awaiting a value that is not a "Thenable"
'@typescript-eslint/explicit-function-return-type': 'error', // functions require return types
'@typescript-eslint/no-this-alias': 'off', // allow 'const self = this'
'@typescript-eslint/await-thenable': 'error', // disallows awaiting a value that is not a "Thenable"
'@typescript-eslint/prefer-function-type': 'off', // conflicts with 'etc/prefer-interface'
'@typescript-eslint/restrict-template-expressions': 'off', // allow values with `any` type in template literals
'@typescript-eslint/return-await': 'error', // disallows unnecessary return await
'jsdoc/require-param': 'off', // do not require jsdoc for params
'jsdoc/require-param-type': 'off' // allow compiler to derive param type
}
Expand Down