feat: default to not include node globals and builtins#578
Merged
Conversation
This PR changes webpack config to not include node globals and built-ins by default. For now theres still a --node flag to allow node globals if needed. `process` is still includes because `readable-stream` will only remove it in v4 nodejs/readable-stream#435 BREAKING CHANGE: browser code will NOT have node globals and builtins available.
56 tasks
Contributor
|
Change looks good, CI is failing though |
achingbrain
approved these changes
Jun 16, 2020
hugomrdias
changed the title
hugomrdias
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes webpack config to not include node globals and built-ins by default.
Tracking issue here ipfs/js-ipfs#2924
For now theres still a --node flag to allow node globals if needed.
processis still included becausereadable-streamwill only remove it in v4 nodejs/readable-stream#435BREAKING CHANGE: browser code will NOT have node globals and builtins available.