Add cancellation check during repository download#301
Open
goelakshita708 wants to merge 1 commit into
Open
Conversation
|
🎉 Thank you @goelakshita708 for submitting a Pull Request! We're excited to review your contribution. Before Review✅ Ensure all CI checks pass ⚡ Want faster reviews and contributor support? Join our Discord community: 🔗 https://discord.gg/FcXuyw2Rs Maintainers and mentors are active there and can help resolve blockers quickly. Happy Contributing! 🚀 |
github-actions
Bot
added
SSoC26
needs-work
|
✅ PR template check passed! @arpit2006 this PR is ready for your review. 🚀 |
Author
|
Please add the GSSoC tag. |
|
✅ PR template check passed! @arpit2006 this PR is ready for your review. 🚀 |
1 similar comment
|
✅ PR template check passed! @arpit2006 this PR is ready for your review. 🚀 |
Collaborator
|
@goelakshita708 , CI issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #258
What this PR does
Adds a cancellation check inside the
download_to_path()download loop. This allows long-running repository downloads to stop immediately when a cancellation request is received instead of continuing until the download finishes.Type of change
ML tier (if applicable)
Stack affected
Changes
Backend
cancel_event.is_set()inside the repository download loop indownload_to_path().Frontend
New dependencies
Database / schema changes
Testing
How did you test this?
Checklist
console.erroror unhandled Python exceptions introducedrequirements.txt/package.jsonupdated if new dependencies added.pkl,.pt, etc.) are gitignored, not committedAnything reviewers should focus on
Please review the cancellation behavior during repository downloads and verify that downloads stop promptly when a cancellation request is triggered.
Screenshots (if UI changed)
N/A (Backend change only)