Predictor fix

[Mokshith08]

Before opening: make sure there is an issue tracking this work, and link it below. PRs without a linked issue may be closed without review.

Linked issue

Closes #278

What this PR does

Fixes a silent data-integrity bug where zip(findings, adjusted_scores) could silently skip updating trailing findings if the score list length mismatched. Adds length validation, defensive assertions, and an index-based update loop to ensure all-or-nothing updates.

Type of change

• Bug fix
• New feature
• ML model / training pipeline
• Refactor (no behaviour change)
• Documentation
• Tests only

ML tier (if applicable)

• Tier 2 — Predictive
• Tier 1 — Triage
• Tier 3 — Autonomous
• Not ML-related

Stack affected

• Backend
• Frontend
• Both

---

Changes

Backend

• Added length-invariant assertions in fp_predictor.py.
• Added mismatch validation and error logging in main.py.
• Replaced zip() with an index-based update loop.

Frontend

• No frontend changes.

New dependencies

• None.

Database / schema changes

• None.

---

Testing

How did you test this?

• Ran pytest tests/test_fp_predictor.py -v.
• Added tests for length mismatch, exception handling, empty inputs, and successful updates.

Checklist

• Tested locally end-to-end
• New ML model falls back gracefully when model file is absent
• No new console.error or unhandled Python exceptions introduced
• Added or updated tests where applicable
• requirements.txt / package.json updated if new dependencies added
• New model files (.pkl, .pt, etc.) are gitignored, not committed

---

Anything reviewers should focus on

• Length validation and assertions.
• All-or-nothing update behavior on score mismatches.

Screenshots (if UI changed)

N/A (Backend-only changes)

[github-actions]

🎉 Thank you @Mokshith08 for submitting a Pull Request!

We're excited to review your contribution.

Before Review

✅ Ensure all CI checks pass
✅ Complete the PR template
✅ Link the related issue

⚡ Want faster reviews and contributor support?

Join our Discord community:

🔗 https://discord.gg/FcXuyw2Rs

Maintainers and mentors are active there and can help resolve blockers quickly.

Happy Contributing! 🚀

[github-actions]

✅ PR template check passed!

@arpit2006 this PR is ready for your review. 🚀

[arpit2006]

@Mokshith08 , Resolve CI issues!

[github-actions]

✅ PR template check passed!

@arpit2006 this PR is ready for your review. 🚀

[github-actions]

✅ PR template check passed!

@arpit2006 this PR is ready for your review. 🚀

[github-actions]

✅ PR template check passed!

@arpit2006 this PR is ready for your review. 🚀