Add accessible labels to dashboard dialog input fields#265
Conversation
|
🎉 Thank you @MamidiDhana for submitting a Pull Request! We're excited to review your contribution. Before Review✅ Ensure all CI checks pass ⚡ Want faster reviews and contributor support? Join our Discord community: 🔗 https://discord.gg/FcXuyw2Rs Maintainers and mentors are active there and can help resolve blockers quickly. Happy Contributing! 🚀 |
|
✅ PR template check passed! @arpit2006 this PR is ready for your review. 🚀 |
arpit2006
left a comment
There was a problem hiding this comment.
LGTM!
✅ Approved
Accessibility labels are correctly wired — this is exactly what was needed.
What was verified:
All three htmlFor ↔ id associations are correctly matched:
Label htmlFor=""repo-url""→Input id=""repo-url""✅Label htmlFor=""repo-ref""→Input id=""repo-ref""✅Label htmlFor=""org-url""→Input id=""org-url""✅
The existing @radix-ui/react-label component (label.tsx) was reused correctly — no new dependencies introduced. The space-y-2 → space-y-4 spacing change in the URL dialog is sensible layout hygiene.
Bonus fix noted 👍
The incidental correction of the 'View' button navigation from "/" → "/dashboard" for non-completed scan jobs is a welcome improvement — routing users back to the dashboard instead of the landing page is the right behaviour.
Minor observation (non-blocking)
The label 'Organization Name' paired with a placeholder of https://github.com/your-org is a slight semantic mismatch, but this pre-exists the PR and is out of scope here.
No regressions. No new dependencies. UI visually unchanged. Screen reader experience meaningfully improved. Merging."
@ionfwsrijan , Ready to Merge!
|
@MamidiDhana , Resolve Merge Conflicts PR is ready to merge |
Linked issue
Closes #251
What this PR does
htmlForandid.Type of change
ML tier (if applicable)
Stack affected
Changes
Backend
Frontend
htmlForandid.New dependencies
Database / schema changes
Testing
How did you test this?
Checklist
console.erroror unhandled Python exceptions introducedrequirements.txt/package.jsonupdated if new dependencies added (Not applicable).pkl,.pt, etc.) are gitignored, not committedAnything reviewers should focus on
Please verify that the dialog input fields now expose meaningful accessible names to screen readers and remain visually unchanged.
Screenshots (if UI changed)
No visual UI changes.