Skip to content

Add accessible labels to dashboard dialog input fields#265

Open
MamidiDhana wants to merge 1 commit into
ionfwsrijan:mainfrom
MamidiDhana:add-accessible-dialog-labels
Open

Add accessible labels to dashboard dialog input fields#265
MamidiDhana wants to merge 1 commit into
ionfwsrijan:mainfrom
MamidiDhana:add-accessible-dialog-labels

Conversation

@MamidiDhana

@MamidiDhana MamidiDhana commented Jul 3, 2026

Copy link
Copy Markdown

Linked issue

Closes #251

What this PR does

  • Adds accessible labels to the input fields in the Import from URL dialog.
  • Adds an accessible label to the input field in the Scan Organization dialog.
  • Associates labels with inputs using htmlFor and id.
  • Preserves the existing UI and functionality while improving accessibility.

Type of change

  • Bug fix
  • New feature
  • ML model / training pipeline
  • Refactor (no behaviour change)
  • Documentation
  • Tests only

ML tier (if applicable)

  • Tier 1 — Triage
  • Tier 2 — Predictive
  • Tier 3 — Autonomous
  • Not ML-related

Stack affected

  • Backend
  • Frontend
  • Both

Changes

Backend

  • None

Frontend

  • Added accessible labels for dialog input fields.
  • Connected labels to inputs using htmlFor and id.

New dependencies

  • None

Database / schema changes

  • None

Testing

How did you test this?

  • Ran the application locally.
  • Opened both dialogs.
  • Verified that each input has a meaningful accessible label.
  • Confirmed keyboard navigation and existing functionality work correctly.

Checklist

  • Tested locally end-to-end (relevant UI tested)
  • New ML model falls back gracefully when model file is absent (Not applicable)
  • No new console.error or unhandled Python exceptions introduced
  • Added or updated tests where applicable
  • requirements.txt / package.json updated if new dependencies added (Not applicable)
  • New model files (.pkl, .pt, etc.) are gitignored, not committed

Anything reviewers should focus on

Please verify that the dialog input fields now expose meaningful accessible names to screen readers and remain visually unchanged.

Screenshots (if UI changed)

No visual UI changes.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

🎉 Thank you @MamidiDhana for submitting a Pull Request!

We're excited to review your contribution.

Before Review

✅ Ensure all CI checks pass
✅ Complete the PR template
✅ Link the related issue

Want faster reviews and contributor support?

Join our Discord community:

🔗 https://discord.gg/FcXuyw2Rs

Maintainers and mentors are active there and can help resolve blockers quickly.

Happy Contributing! 🚀

@github-actions github-actions Bot added SSoC26 needs-work Work needed backend Backend issues bug Something isn't working frontend Frontend issues and removed needs-work Work needed labels Jul 3, 2026
@github-actions github-actions Bot requested a review from arpit2006 July 3, 2026 16:37
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

PR template check passed!

@arpit2006 this PR is ready for your review. 🚀

@arpit2006 arpit2006 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
✅ Approved

Accessibility labels are correctly wired — this is exactly what was needed.

What was verified:

All three htmlForid associations are correctly matched:

  • Label htmlFor=""repo-url""Input id=""repo-url""
  • Label htmlFor=""repo-ref""Input id=""repo-ref""
  • Label htmlFor=""org-url""Input id=""org-url""

The existing @radix-ui/react-label component (label.tsx) was reused correctly — no new dependencies introduced. The space-y-2space-y-4 spacing change in the URL dialog is sensible layout hygiene.

Bonus fix noted 👍

The incidental correction of the 'View' button navigation from "/""/dashboard" for non-completed scan jobs is a welcome improvement — routing users back to the dashboard instead of the landing page is the right behaviour.

Minor observation (non-blocking)

The label 'Organization Name' paired with a placeholder of https://github.com/your-org is a slight semantic mismatch, but this pre-exists the PR and is out of scope here.

No regressions. No new dependencies. UI visually unchanged. Screen reader experience meaningfully improved. Merging."

@ionfwsrijan , Ready to Merge!

@arpit2006

Copy link
Copy Markdown
Collaborator

@MamidiDhana , Resolve Merge Conflicts PR is ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Accessible Labels to Dialog Input Fields

2 participants