feat(dumper): allow subclasses to override record copy behavior#356
Open
max-moser wants to merge 2 commits into
Open
feat(dumper): allow subclasses to override record copy behavior#356max-moser wants to merge 2 commits into
max-moser wants to merge 2 commits into
Conversation
* because deepcopy can be a very costly operation and overkill in some cases, we allow subclasses of ``Dumper`` to provide their own record copy strategy
* change the responsibility about deciding on an appropriate copy mechanism before data loading from being baked into the record class to the dumper class * this makes it easier to change the copy mechanism depending on the circumstances towards which the dumper should be geared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because deepcopy can be a very costly operation and overkill in some cases, we allow subclasses of
Dumperto provide their own record copy strategy.