chore(deprecation)!: remove deprecated code paths requiring inspect#355
Open
max-moser wants to merge 1 commit into
Open
chore(deprecation)!: remove deprecated code paths requiring inspect#355max-moser wants to merge 1 commit into
max-moser wants to merge 1 commit into
Conversation
Contributor
|
Testrig is all green :) 
|
Contributor
Author
|
Thank you kindly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've encountered the
inspectcall in thepost_dump()code path at least once.The code path necessitating this check has been deprecated for several years now.
So while this is not a huge performance hog, it's still an easy win if we axe it.
TODO: