Skip to content

[helm] Add TLS support on yugabyte#1182

Merged
barroco merged 2 commits into
interuss:masterfrom
Orbitalize:yugabyte_ssl
Jun 3, 2025
Merged

[helm] Add TLS support on yugabyte#1182
barroco merged 2 commits into
interuss:masterfrom
Orbitalize:yugabyte_ssl

Conversation

@the-glu

@the-glu the-glu commented May 1, 2025

Copy link
Copy Markdown
Member

This PR follow #1159, you probably want to read the latest commit only.

It does add TLS support for yugabyte in helm charts, with a few open problems:

  • I created new specific scripts for certs generation. They should probably be merged with existing/cockroachdb ones.
  • No support for multiple clusters yet on the certificate side
  • The following PR is needed: Add 'provided' flag for tls certificates yugabyte/charts#203
  • No specific documentation yet, however no changes expect the usage of new scripts to generate/apply certificates

This PR is there as a first draft for feedback and future refinements :)

@the-glu the-glu requested a review from barroco May 1, 2025 14:05
@the-glu the-glu marked this pull request as draft May 1, 2025 14:06

@mickmis mickmis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early review upon request from @the-glu, looks good overall.

Comment thread build/make-certs-yugabyte.py Outdated
Comment thread build/make-certs-yugabyte.py Outdated
Comment thread build/apply-certs-yugabyte.sh Outdated

@barroco barroco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @the-glu for this PR. Let's rescope it to the helm changes to support multi-cluster setup and to read secrets. We will address certificate generation and secret upload in a subsequent PR.

Comment thread .gitignore Outdated
Comment thread build/apply-certs-yugabyte.sh Outdated
Comment thread build/make-certs-yugabyte.py Outdated
Comment thread deploy/services/helm-charts/dss/values.yaml Outdated
Comment thread deploy/services/helm-charts/dss/values.yaml Outdated
Comment thread deploy/services/helm-charts/dss/templates/_volumes.tpl
Comment thread deploy/services/helm-charts/dss/values.yaml Outdated
Comment thread deploy/services/helm-charts/dss/values.yaml Outdated
Comment thread deploy/services/helm-charts/dss/values.yaml Outdated
Comment thread deploy/services/helm-charts/dss/values.yaml Outdated
@the-glu the-glu marked this pull request as ready for review June 3, 2025 07:35
@barroco barroco merged commit 43fce09 into interuss:master Jun 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants