feat: Add Share API endpoints and AES-256-GCM cipher for public links#40
Merged
Conversation
- add create sharing request
-add Aes cipher
sg-gs
reviewed
May 7, 2026
- Validate the OSStatus return of `SecRandomCopyBytes` with a guard statement to avoid using uninitialized/zero-filled byte arrays if CSPRNG fails. - Propagate errors by making `generateRandomUrlSafeString` throwing (`throws`).
TamaraFinogina
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the necessary cryptographic tools, API endpoints, and models to support creating Public Share Links
Changes
Added a new InternxtAESCipher class using Apple's CryptoKit.
Implements AES-256-GCM with PBKDF2-HMAC-SHA512 (2145 iterations) to exactly match the web client's encryption spec for public shares.
Added a URL-safe random string generator for share codes.
2. API & Models (DriveAPI.swift & DriveTypes.swift)
Models: Added CreateSharingPayload, CreateSharingResponse, and ShareDomainsResponse.
Endpoints: Added createSharing() (POST /sharings/) and getShareDomains() (GET gateway share domains).