Skip to content

[_] put keystore salt inside the keystore#54

Merged
TamaraFinogina merged 4 commits into
masterfrom
put_salt_inside
Apr 28, 2026
Merged

[_] put keystore salt inside the keystore#54
TamaraFinogina merged 4 commits into
masterfrom
put_salt_inside

Conversation

@TamaraFinogina
Copy link
Copy Markdown
Contributor

@TamaraFinogina TamaraFinogina commented Apr 24, 2026

Description

Put keystore salt inside keystore

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

unit tests

@TamaraFinogina TamaraFinogina self-assigned this Apr 24, 2026
@TamaraFinogina TamaraFinogina requested a review from xabg2 April 24, 2026 08:10
Copy link
Copy Markdown

@xabg2 xabg2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we just need pass the mnemonic now and we will get the key directly, right? Removing extra steps on the client side.

@TamaraFinogina
Copy link
Copy Markdown
Contributor Author

@xabg2 Correct, but with keystore it's the password. For the rest of the keys (database, draft) it's mnemonic

@sonarqubecloud
Copy link
Copy Markdown

@TamaraFinogina TamaraFinogina merged commit fef47a4 into master Apr 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants