Skip to content

[IN-115] chore: validate file size check for linux >= v2.5.4 #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apsantiso merged 2 commits into from
May 13, 2026
+11 −7
Merged

[IN-115] chore: validate file size check for linux >= v2.5.4 #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c48ae95
chore: validate file size check for linux >=v2.5.4
apsantiso May 13, 2026
931ad6f
chore: fix unit tests
apsantiso May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/core/buckets/helpers/uploadValidation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ import { getContext } from "../../../requestContext";
const EXEMPT_CLIENTS: Record<string, string> = {
"internxt-cli": "1.6.3",
"drive-desktop-windows": "2.6.6",
// All versions
"drive-desktop-linux": '*',
"drive-desktop-linux": '2.5.3',
};

export function shouldEnforceUploadValidation(): boolean {
Expand Down
15 changes: 10 additions & 5 deletions tests/lib/core/buckets/helpers/uploadValidation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,21 @@ describe('shouldEnforceUploadValidation()', () => {
});
});

describe('When the client is drive-desktop-linux (all versions exempt)', () => {
it('When called with any version, then it should not enforce', () => {
mockContext('drive-desktop-linux', '0.0.1');
describe('When the client is drive-desktop-linux (exempt up to 2.5.3)', () => {
it('When version is below the exempt threshold, then it should not enforce', () => {
mockContext('drive-desktop-linux', '2.5.2');
expect(shouldEnforceUploadValidation()).toBe(false);
});

it('When called with a high version, then it should not enforce', () => {
mockContext('drive-desktop-linux', '99.99.99');
it('When version equals the exempt threshold, then it should not enforce', () => {
mockContext('drive-desktop-linux', '2.5.3');
expect(shouldEnforceUploadValidation()).toBe(false);
});

it('When version is above the exempt threshold, then it should enforce', () => {
mockContext('drive-desktop-linux', '2.5.4');
expect(shouldEnforceUploadValidation()).toBe(true);
});
});

describe('When the client is internxt-cli (exempt up to 1.6.3)', () => {
Expand Down
Loading