Skip to content

remove unused carousel i18n input#12951

Open
rakshith1928 wants to merge 1 commit into
internetarchive:masterfrom
rakshith1928:remove-unused-carousel-i18n-input
Open

remove unused carousel i18n input#12951
rakshith1928 wants to merge 1 commit into
internetarchive:masterfrom
rakshith1928:remove-unused-carousel-i18n-input

Conversation

@rakshith1928

Copy link
Copy Markdown

Closes #12870

refactor

Technical

Removes the unused carousel_i18n_input() helper and the associated render_once block from openlibrary/templates/books/custom_carousel.html.

Since #12853 embeds translation strings directly into each carousel's config.i18n, the shared hidden input is no longer required. No functional changes are introduced.

Testing

Start Open Library locally.
Visit pages containing book carousels.
Verify that carousels load correctly.
Verify that loading text and other translated strings continue to appear as expected.
Confirm there are no JavaScript console errors related to carousel i18n.

Screenshot

N/A (no UI changes)

Stakeholders

@lokesh

@mekarpeles

Copy link
Copy Markdown
Member

Welcome to Open Library, @rakshith1928! Thank you for your first contribution.

🤖 Copilot has been assigned for an initial review.

The linked issue (#12870) hasn't been triaged yet — triage happens on Mondays and Fridays. There are currently 82 open non-draft PRs ahead of yours.

PR triage checklist (maintainers / Richy)
  • PR description — not empty; explains what the change does and how to verify it
  • References an issue — PR body contains a #NNN reference
    • Linked issue is triaged — has a Priority: * label (not just Needs: Triage)
    • Linked issue is assigned — has at least one assignee
  • Commit history clean — no WIP/fixup/conflict noise; commit messages are meaningful
  • CI passing — no failing check-runs
  • Test cases present — pure template deletion; no logic changes requiring tests
  • Proof of testing — PR body describes how to verify the change

Note

This comment was automatically generated by Richy, via PAM, Open Library's Project AI Manager, on behalf of @mekarpeles. Richy is designed to provide status visibility, perform basic project management functions and relevant codebase research, and provide actionable feedback so contributors aren't left waiting.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the now-redundant shared carousel i18n hidden input from custom_carousel.html, relying on the per-carousel config.i18n embedded in each carousel’s data-config (as introduced in #12853).

Changes:

  • Removes the unused carousel_i18n_input() helper.
  • Removes the render_once('books/custom_carousel.i18n-strings') block that emitted the shared carousel-i18n-strings hidden input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove redundant render_once i18n hidden input in custom_carousel.html (follow-up to #12853)

4 participants