remove unused carousel i18n input#12951
Conversation
|
Welcome to Open Library, @rakshith1928! Thank you for your first contribution. 🤖 Copilot has been assigned for an initial review. The linked issue (#12870) hasn't been triaged yet — triage happens on Mondays and Fridays. There are currently 82 open non-draft PRs ahead of yours. PR triage checklist (maintainers / Richy)
Note This comment was automatically generated by Richy, via PAM, Open Library's Project AI Manager, on behalf of @mekarpeles. Richy is designed to provide status visibility, perform basic project management functions and relevant codebase research, and provide actionable feedback so contributors aren't left waiting. |
There was a problem hiding this comment.
Pull request overview
This PR removes the now-redundant shared carousel i18n hidden input from custom_carousel.html, relying on the per-carousel config.i18n embedded in each carousel’s data-config (as introduced in #12853).
Changes:
- Removes the unused
carousel_i18n_input()helper. - Removes the
render_once('books/custom_carousel.i18n-strings')block that emitted the sharedcarousel-i18n-stringshidden input.
Closes #12870
refactor
Technical
Removes the unused carousel_i18n_input() helper and the associated render_once block from openlibrary/templates/books/custom_carousel.html.
Since #12853 embeds translation strings directly into each carousel's config.i18n, the shared hidden input is no longer required. No functional changes are introduced.
Testing
Start Open Library locally.
Visit pages containing book carousels.
Verify that carousels load correctly.
Verify that loading text and other translated strings continue to appear as expected.
Confirm there are no JavaScript console errors related to carousel i18n.
Screenshot
N/A (no UI changes)
Stakeholders
@lokesh