Adding primitive support for likes #12768#12932
Open
shreya8040 wants to merge 2 commits into
Open
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12768
Added a likes table to the Open Library database, a openlibrary/core/likes.py model, and a small set of backend API endpoints.
Technical
likestable DDL toscripts/db_setup.pyopenlibrary/core/likes.pywithLikesclass (like,unlike,dislike,get_count,get_for_patron,patron_liked)openlibrary/plugins/upstream/code.py:POST /api/like— like or dislike a record (auth required)DELETE /api/like— remove a like (auth required)GET /api/likes— get like/dislike count +patron_likedflagGET /api/patron/likes— get all likes by a patron (paginated)# TODOcomment inlikes.pydocumenting the redirect/merge gap and pointing toresolve_redirects_bulkTesting
No UI changes — backend only. Run unit tests with:
docker compose run --rm home pytest openlibrary/plugins/openlibrary/tests/test_likes.pyNote: test suite currently blocked by upstream
NameError: name 'Locale' is not definedinconftest.py(unrelated to this PR).Screenshot
Stakeholders
@mekarpeles