Add transaction_details table to local instances#12319
Conversation
|
Thanks for the PR, @jimchamp! @mekarpeles is assigned to this PR and currently has:
Possible improvements for this PR
PR triage checklist (maintainers / Pam)
Note This comment was automatically generated by Pam, Open Library's Project AI Manager, on behalf of @mekarpeles. Pam is designed to provide status visibility, perform basic project management functions and relevant codebase research, and provide actionable feedback so contributors aren't left waiting. |
There was a problem hiding this comment.
Pull request overview
Adds local-development database support for a new transaction_details table intended to record richer per-change transaction metadata in Infobase-backed Open Library instances.
Changes:
- Adds
transaction_detailsDDL to the local dev DB seed dump (dev_db.pg_dump). - Adds
transaction_detailsDDL to the Infobase schema bootstrap SQL (openlibrary/core/infobase_schema.sql). - Enables a new Infobase config flag in
conf/infobase.ymlintended to turn on writes totransaction_details.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/dev-instance/dev_db.pg_dump | Seeds local dev DB with transaction_details table (plus regenerated dump output). |
| openlibrary/core/infobase_schema.sql | Adds transaction_details to Infobase bootstrap schema. |
| conf/infobase.yml | Introduces use_transaction_details_table: true config toggle. |
|
This PR updates the DDL on Infogami such that it matches that in |
…2319) * Create `transaction_details` table in local instances * Enable writes to `transaction_details` in local instances --------- Co-authored-by: Mek <michael.karpeles@gmail.com>
…2319) * Create `transaction_details` table in local instances * Enable writes to `transaction_details` in local instances --------- Co-authored-by: Mek <michael.karpeles@gmail.com>
…2319) * Create `transaction_details` table in local instances * Enable writes to `transaction_details` in local instances --------- Co-authored-by: Mek <michael.karpeles@gmail.com>
Follows #12210 (Pertinent comment)
Related to internetarchive/infogami#279
Makes the following updates, which only affect local development environments:
transaction_detailstable to the data dump which is used for initial data loads.transaction_detailstable to theinfobase_schema.sqlfile.transaction_detailstable.The new DDL in the
infobase_schema.sqlfile is slightly different from the DDL called when Infogami is installed, and should be used to create the table in production.Technical
Testing
Screenshot
Stakeholders