Skip to content

Add transaction_details table to local instances#12319

Merged
mekarpeles merged 3 commits into
internetarchive:masterfrom
jimchamp:prep-for-txn-details
Apr 13, 2026
Merged

Add transaction_details table to local instances#12319
mekarpeles merged 3 commits into
internetarchive:masterfrom
jimchamp:prep-for-txn-details

Conversation

@jimchamp

@jimchamp jimchamp commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

Follows #12210 (Pertinent comment)
Related to internetarchive/infogami#279

Makes the following updates, which only affect local development environments:

  1. Adds DDL for transaction_details table to the data dump which is used for initial data loads.
  2. Adds DDL for transaction_details table to the infobase_schema.sql file.
  3. Updates infobase configuration to enable writing to transaction_details table.

The new DDL in the infobase_schema.sql file is slightly different from the DDL called when Infogami is installed, and should be used to create the table in production.

Technical

Testing

Screenshot

Stakeholders

Copilot AI review requested due to automatic review settings April 9, 2026 01:28
@mekarpeles

Copy link
Copy Markdown
Member

Thanks for the PR, @jimchamp!

@mekarpeles is assigned to this PR and currently has:

  • 1 open PR(s) of equal or higher priority to review first

Possible improvements for this PR

  • Proof of testing — The Testing section is empty. Even a brief note on how you verified the table was created locally (e.g., "spun up the dev instance and confirmed the table existed") helps reviewers follow along.
PR triage checklist (maintainers / Pam)
  • PR description — not empty; explains what the change does and how to verify it
  • References an issue — PR body contains a #NNN reference
    • Linked issue is triaged — has a Priority: * label (not just Needs: Triage)
    • Linked issue is assigned — has at least one assignee
  • Commit history clean — no WIP/fixup/conflict noise; commit messages are meaningful
  • CI passing — no failing check-runs
  • Test cases present — schema/config-only change; unit tests not applicable
  • Proof of testing — PR body includes a description of what was tested, a screenshot, or a video

Note

This comment was automatically generated by Pam, Open Library's Project AI Manager, on behalf of @mekarpeles. Pam is designed to provide status visibility, perform basic project management functions and relevant codebase research, and provide actionable feedback so contributors aren't left waiting.

@mekarpeles mekarpeles added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Apr 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds local-development database support for a new transaction_details table intended to record richer per-change transaction metadata in Infobase-backed Open Library instances.

Changes:

  • Adds transaction_details DDL to the local dev DB seed dump (dev_db.pg_dump).
  • Adds transaction_details DDL to the Infobase schema bootstrap SQL (openlibrary/core/infobase_schema.sql).
  • Enables a new Infobase config flag in conf/infobase.yml intended to turn on writes to transaction_details.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
scripts/dev-instance/dev_db.pg_dump Seeds local dev DB with transaction_details table (plus regenerated dump output).
openlibrary/core/infobase_schema.sql Adds transaction_details to Infobase bootstrap schema.
conf/infobase.yml Introduces use_transaction_details_table: true config toggle.

Comment thread scripts/dev-instance/dev_db.pg_dump
Comment thread openlibrary/core/infobase_schema.sql
Comment thread conf/infobase.yml
@jimchamp

jimchamp commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator Author

This PR updates the DDL on Infogami such that it matches that in infobase_schema.sql.

@mekarpeles mekarpeles self-assigned this Apr 13, 2026
@mekarpeles mekarpeles merged commit ec79c37 into internetarchive:master Apr 13, 2026
2 checks passed
@github-actions github-actions Bot removed the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Apr 13, 2026
jack-wines pushed a commit to jack-wines/openlibrary that referenced this pull request Apr 18, 2026
…2319)

* Create `transaction_details` table in local instances
* Enable writes to `transaction_details` in local instances
---------

Co-authored-by: Mek <michael.karpeles@gmail.com>
@jimchamp jimchamp deleted the prep-for-txn-details branch April 23, 2026 17:00
IvanPisquiy06 pushed a commit to IvanPisquiy06/openlibrary that referenced this pull request Apr 27, 2026
…2319)

* Create `transaction_details` table in local instances
* Enable writes to `transaction_details` in local instances
---------

Co-authored-by: Mek <michael.karpeles@gmail.com>
Sadashii pushed a commit to Sadashii/openlibrary that referenced this pull request May 11, 2026
…2319)

* Create `transaction_details` table in local instances
* Enable writes to `transaction_details` in local instances
---------

Co-authored-by: Mek <michael.karpeles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants