Conversation
There was a problem hiding this comment.
Pull request overview
Adds a package-level toggle for per-query database logging, gated by a new TL_LOG_QUERIES environment variable, to avoid flooding logs when TRACE logging is enabled.
Changes:
- Introduces
TL_LOG_QUERIESenv var gating via a newqueryLoggingflag. - Adds
LogQueries()getter andSetLogQueries(bool)setter for controlling query logging.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+58
to
+61
| // SetLogQueries enables or disables per-query database logging at runtime. | ||
| func SetLogQueries(v bool) { | ||
| queryLogging = v | ||
| } |
Contributor
Author
|
Just did this directly in transitland-lib since that's where querylogger lives |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in gate for per-query database logging. Previously, enabling TRACE-level logging would emit one line per query, flooding output. This introduces a separate
TL_LOG_QUERIESswitch so query logging can be turned on independently and stays off by default.Changes
queryLoggingflag, initialized fromTL_LOG_QUERIES=true(off by default)LogQueries() bool— reports whether per-query logging is enabledSetLogQueries(bool)— toggles it at runtimeNotes
Callers that emit per-query logs should gate them on
log.LogQueries(). Default behavior is unchanged — query logging stays silent unless explicitly enabled via the env var orSetLogQueries.